Re: [Qemu-devel] [PATCH] blockdev: no need to drain in qmp_block_commit

2015-06-15 Thread Jeff Cody
On Thu, May 28, 2015 at 04:21:43PM +0200, Paolo Bonzini wrote: > Draining is not necessary, I/O can happen as soon as the > commit coroutine yields. Draining can be necessary before > reopening the file for read/write, or while modifying the > backing file chain, but that is done separately in > b

Re: [Qemu-devel] [PATCH] blockdev: no need to drain in qmp_block_commit

2015-05-28 Thread Fam Zheng
- Original Message - > Draining is not necessary, I/O can happen as soon as the > commit coroutine yields. Draining can be necessary before > reopening the file for read/write, or while modifying the > backing file chain, but that is done separately in > bdrv_reopen_multiple or bdrv_clos

[Qemu-devel] [PATCH] blockdev: no need to drain in qmp_block_commit

2015-05-28 Thread Paolo Bonzini
Draining is not necessary, I/O can happen as soon as the commit coroutine yields. Draining can be necessary before reopening the file for read/write, or while modifying the backing file chain, but that is done separately in bdrv_reopen_multiple or bdrv_close; this particular bdrv_drain_all does no