Re: [Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-12 Thread John Snow
On 2/12/19 2:36 PM, Eric Blake wrote: > On 2/6/19 11:02 AM, John Snow wrote: >> When bitmaps are persistent, they may incur a disk read or write when bitmaps >> are added or removed. For configurations like virtio-dataplane, failing to >> acquire this lock will abort QEMU when disk IO occurs. >>

Re: [Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-12 Thread Eric Blake
On 2/6/19 11:02 AM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part of t

Re: [Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-11 Thread John Snow
On 2/6/19 12:02 PM, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as part o

Re: [Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-06 Thread Vladimir Sementsov-Ogievskiy
add Paolo 06.02.2019 20:02, John Snow wrote: > When bitmaps are persistent, they may incur a disk read or write when bitmaps > are added or removed. For configurations like virtio-dataplane, failing to > acquire this lock will abort QEMU when disk IO occurs. > > We used to acquire aio_context as

[Qemu-devel] [PATCH] blockdev: acquire aio_context for bitmap add/remove

2019-02-06 Thread John Snow
When bitmaps are persistent, they may incur a disk read or write when bitmaps are added or removed. For configurations like virtio-dataplane, failing to acquire this lock will abort QEMU when disk IO occurs. We used to acquire aio_context as part of the bitmap lookup, so re-introduce the lock for