Re: [Qemu-devel] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-11-02 Thread Stefan Hajnoczi
On Sun, Nov 01, 2015 at 08:50:36PM +0300, Denis V. Lunev wrote: > On 10/30/2015 06:57 PM, Stefan Hajnoczi wrote: > >This one slipped through. Although we acquire AioContext when > >committing all devices we don't for just a single device. > > > >AioContext must be acquired before calling bdrv_*()

Re: [Qemu-devel] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-11-01 Thread Denis V. Lunev
On 10/30/2015 06:57 PM, Stefan Hajnoczi wrote: This one slipped through. Although we acquire AioContext when committing all devices we don't for just a single device. AioContext must be acquired before calling bdrv_*() functions to synchronize access with other threads that may be using the Aio

[Qemu-devel] [PATCH] blockdev: acquire AioContext in hmp_commit()

2015-10-30 Thread Stefan Hajnoczi
This one slipped through. Although we acquire AioContext when committing all devices we don't for just a single device. AioContext must be acquired before calling bdrv_*() functions to synchronize access with other threads that may be using the AioContext. Signed-off-by: Stefan Hajnoczi --- bl