Re: [Qemu-devel] [PATCH] block-backend: Always notify on blk_eject

2016-10-31 Thread John Snow
On 10/31/2016 10:13 AM, Kevin Wolf wrote: Am 28.10.2016 um 23:30 hat John Snow geschrieben: On 10/28/2016 05:23 PM, John Snow wrote: blk_eject is only used by scsi-disk and atapi, and in both cases we only attempt to invoke blk_eject if we have a bona-fide change in tray state. The "issue" h

Re: [Qemu-devel] [PATCH] block-backend: Always notify on blk_eject

2016-10-31 Thread Kevin Wolf
Am 28.10.2016 um 23:30 hat John Snow geschrieben: > On 10/28/2016 05:23 PM, John Snow wrote: > >blk_eject is only used by scsi-disk and atapi, and in both cases we > >only attempt to invoke blk_eject if we have a bona-fide change in > >tray state. > > > >The "issue" here is that the tray state does

Re: [Qemu-devel] [PATCH] block-backend: Always notify on blk_eject

2016-10-28 Thread John Snow
On 10/28/2016 05:23 PM, John Snow wrote: blk_eject is only used by scsi-disk and atapi, and in both cases we only attempt to invoke blk_eject if we have a bona-fide change in tray state. The "issue" here is that the tray state does not generate a QMP event unless there is a medium/BDS attached

[Qemu-devel] [PATCH] block-backend: Always notify on blk_eject

2016-10-28 Thread John Snow
blk_eject is only used by scsi-disk and atapi, and in both cases we only attempt to invoke blk_eject if we have a bona-fide change in tray state. The "issue" here is that the tray state does not generate a QMP event unless there is a medium/BDS attached to the device, so if libvirt et al are waiti