Re: [Qemu-devel] [PATCH] block: nvme: correct the nvme queue id check

2016-10-22 Thread P J P
+-- On Sat, 22 Oct 2016, Peter Maydell wrote --+ | Secondly, it's almost the same as this cleanup | patch from Thomas Huth that's already in qemu-trivial: | http://patchwork.ozlabs.org/patch/681349/ | | except that your version is removing the ! | negations from the return value. | | Can you expl

Re: [Qemu-devel] [PATCH] block: nvme: correct the nvme queue id check

2016-10-22 Thread Peter Maydell
On 22 October 2016 at 13:09, P J P wrote: > From: Prasad J Pandit > > NVME Express Controller has two queues, submission & completion > queue. When creating a new queue object, 'nvme_create_sq' and > 'nvme_create_cq' routines incorrectly check the queue id field. > It could lead to an OOB access

[Qemu-devel] [PATCH] block: nvme: correct the nvme queue id check

2016-10-22 Thread P J P
From: Prasad J Pandit NVME Express Controller has two queues, submission & completion queue. When creating a new queue object, 'nvme_create_sq' and 'nvme_create_cq' routines incorrectly check the queue id field. It could lead to an OOB access issue. Correct the queue id check to avoid it. Report