Re: [Qemu-devel] [PATCH] block: fix permission update in bdrv_replace_node

2019-08-26 Thread Max Reitz
On 24.08.19 12:07, Vladimir Sementsov-Ogievskiy wrote: > It's wrong to OR shared permissions. It may lead to crash on further > permission updates. > Also, no needs to consider previously calculated permissions, as at > this point we already bind all new parents and bdrv_get_cumulative_perm > resul

[Qemu-devel] [PATCH] block: fix permission update in bdrv_replace_node

2019-08-24 Thread Vladimir Sementsov-Ogievskiy
It's wrong to OR shared permissions. It may lead to crash on further permission updates. Also, no needs to consider previously calculated permissions, as at this point we already bind all new parents and bdrv_get_cumulative_perm result is enough. So fix the bug by just set permissions by bdrv_get_c