Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-12-01 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >> > On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: >> >> Use the external qemu-timer API instead. >> >> >> >> Cc: kw...@redhat.com >> >> Cc: stefa...@redh

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-12-01 Thread Stefan Hajnoczi
On Fri, Nov 28, 2014 at 02:41:54PM +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: > >> Use the external qemu-timer API instead. > >> > >> Cc: kw...@redhat.com > >> Cc: stefa...@redhat.com > >> Signed-off-by: Paolo Bo

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: >> Use the external qemu-timer API instead. >> >> Cc: kw...@redhat.com >> Cc: stefa...@redhat.com >> Signed-off-by: Paolo Bonzini >> --- >> block/accounting.c | 6 -- >> block/raw-posix.c | 8

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-28 Thread Stefan Hajnoczi
On Wed, Nov 26, 2014 at 03:01:02PM +0100, Paolo Bonzini wrote: > Use the external qemu-timer API instead. > > Cc: kw...@redhat.com > Cc: stefa...@redhat.com > Signed-off-by: Paolo Bonzini > --- > block/accounting.c | 6 -- > block/raw-posix.c | 8 > 2 files changed, 8 insertions(+)

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 18:45, Markus Armbruster wrote: >> > >> > Because no one else calls it directly, it is an internal function. I >> > want to keep it confined to qemu-timer.c (and possibly cpus.c in the >> > icount implementation, but maybe not even that is necessary). > That's a perfectly sensible

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 27/11/2014 10:19, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Use the external qemu-timer API instead. >> >> Ignorant question: why? > > Because no one else calls it directly, it is an internal function. I > want to keep it confined to qemu-timer.c (and

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 17:44, Stefan Hajnoczi wrote: > On Thu, Nov 27, 2014 at 10:19:45AM +0100, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Use the external qemu-timer API instead. >> >> Ignorant question: why? > > Patch seems fine but I concur with Markus. Let's add the rationale to > th

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Stefan Hajnoczi
On Thu, Nov 27, 2014 at 10:19:45AM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > Use the external qemu-timer API instead. > > Ignorant question: why? Patch seems fine but I concur with Markus. Let's add the rationale to the commit description. pgpj67g1P8W4L.pgp Description: P

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Paolo Bonzini
On 27/11/2014 10:19, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Use the external qemu-timer API instead. > > Ignorant question: why? Because no one else calls it directly, it is an internal function. I want to keep it confined to qemu-timer.c (and possibly cpus.c in the icount imp

Re: [Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > Use the external qemu-timer API instead. Ignorant question: why?

[Qemu-devel] [PATCH] block: do not use get_clock()

2014-11-26 Thread Paolo Bonzini
Use the external qemu-timer API instead. Cc: kw...@redhat.com Cc: stefa...@redhat.com Signed-off-by: Paolo Bonzini --- block/accounting.c | 6 -- block/raw-posix.c | 8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/block/accounting.c b/block/accounting.c index edbb