Re: [Qemu-devel] [PATCH] block: bdrv_invalidate_cache: invalidate children first

2017-02-01 Thread Max Reitz
On 31.01.2017 12:23, Vladimir Sementsov-Ogievskiy wrote: > Current implementation invalidates firstly parent bds and then its > children. This leads to the following bug: > > after incoming migration, in bdrv_invalidate_cache_all: > 1. invalidate parent bds - reopen it with BDRV_O_INACTIVE cleared

Re: [Qemu-devel] [PATCH] block: bdrv_invalidate_cache: invalidate children first

2017-02-01 Thread Stefan Hajnoczi
On Tue, Jan 31, 2017 at 02:23:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Current implementation invalidates firstly parent bds and then its > children. This leads to the following bug: > > after incoming migration, in bdrv_invalidate_cache_all: > 1. invalidate parent bds - reopen it with BD

Re: [Qemu-devel] [PATCH] block: bdrv_invalidate_cache: invalidate children first

2017-01-31 Thread Max Reitz
On 31.01.2017 12:23, Vladimir Sementsov-Ogievskiy wrote: > Current implementation invalidates firstly parent bds and then its > children. This leads to the following bug: > > after incoming migration, in bdrv_invalidate_cache_all: > 1. invalidate parent bds - reopen it with BDRV_O_INACTIVE cleared

Re: [Qemu-devel] [PATCH] block: bdrv_invalidate_cache: invalidate children first

2017-01-31 Thread Vladimir Sementsov-Ogievskiy
v2 missed in topic, sorry for that. First version was "[PATCH] block: bdrv_invalidate_cache_all: invalidate children first" -- Best regards, Vladimir

[Qemu-devel] [PATCH] block: bdrv_invalidate_cache: invalidate children first

2017-01-31 Thread Vladimir Sementsov-Ogievskiy
Current implementation invalidates firstly parent bds and then its children. This leads to the following bug: after incoming migration, in bdrv_invalidate_cache_all: 1. invalidate parent bds - reopen it with BDRV_O_INACTIVE cleared 2. child is not yet invalidated 3. parent check that its BDRV_O_IN