Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 10:28, Kevin Wolf ha scritto: Breaking this invariant means that you have a very small window where {'execute':'cont'} would actually not restart the VM. I think this should be fixed by dropping the request in vm_start, like this: [...] Sounds like an option. Do we need to send a

Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-04 Thread Kevin Wolf
Am 03.06.2014 um 17:51 hat Paolo Bonzini geschrieben: > Il 03/06/2014 16:37, Kevin Wolf ha scritto: > > Am 03.06.2014 um 16:16 hat Paolo Bonzini geschrieben: > >> With virtio-blk dataplane, I/O errors might occur while QEMU is > >> not in the main I/O thread. However, it's invalid to call vm_stop

Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-03 Thread Paolo Bonzini
Il 03/06/2014 16:37, Kevin Wolf ha scritto: > Am 03.06.2014 um 16:16 hat Paolo Bonzini geschrieben: >> With virtio-blk dataplane, I/O errors might occur while QEMU is >> not in the main I/O thread. However, it's invalid to call vm_stop >> when we're neither in a VCPU thread nor in the main I/O thr

[Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-03 Thread Paolo Bonzini
With virtio-blk dataplane, I/O errors might occur while QEMU is not in the main I/O thread. However, it's invalid to call vm_stop when we're neither in a VCPU thread nor in the main I/O thread, even if we were to take the iothread mutex around it. To avoid this problem, simply raise a request to

Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-03 Thread Kevin Wolf
Am 03.06.2014 um 16:16 hat Paolo Bonzini geschrieben: > With virtio-blk dataplane, I/O errors might occur while QEMU is > not in the main I/O thread. However, it's invalid to call vm_stop > when we're neither in a VCPU thread nor in the main I/O thread, > even if we were to take the iothread mutex