Re: [Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-20 Thread Eric Blake
On 07/09/2018 04:32 AM, Kevin Wolf wrote: Am 06.07.2018 um 23:20 hat Eric Blake geschrieben: On 07/06/2018 11:45 AM, Kevin Wolf wrote: If the virtual disk size isn't aligned to full clusters, bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full cluster completed, which will let i

Re: [Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-09 Thread Kevin Wolf
Am 06.07.2018 um 23:20 hat Eric Blake geschrieben: > On 07/06/2018 11:45 AM, Kevin Wolf wrote: > > If the virtual disk size isn't aligned to full clusters, > > bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full > > cluster completed, which will let it run into an assertion failure:

Re: [Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-06 Thread Eric Blake
On 07/06/2018 11:45 AM, Kevin Wolf wrote: If the virtual disk size isn't aligned to full clusters, bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full cluster completed, which will let it run into an assertion failure: qemu-io: block/io.c:1203: bdrv_co_do_copy_on_readv: Assertion

[Qemu-devel] [PATCH] block: Fix copy-on-read crash with partial final cluster

2018-07-06 Thread Kevin Wolf
If the virtual disk size isn't aligned to full clusters, bdrv_co_do_copy_on_readv() may get pnum == 0 before having the full cluster completed, which will let it run into an assertion failure: qemu-io: block/io.c:1203: bdrv_co_do_copy_on_readv: Assertion `skip_bytes < pnum' failed. Check for EOF