Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Eric Blake
On 03/19/2015 05:29 AM, Kevin Wolf wrote: > Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit >> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUN

Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Markus Armbruster
Kevin Wolf writes: > Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit >> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace >> them.

Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-19 Thread Kevin Wolf
Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit > b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace > them. > > Signed-off-by: Markus

Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
I should mention that I hunted down all new instances of funky error classes since 2.2. This is the last one. The other two are: [PATCH] vnc: Fix QMP change not to use funky error class [PATCH] block: Fix block-set-write-threshold not to use funky error class

[Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace them. Signed-off-by: Markus Armbruster --- blockdev.c | 8 qapi/block-core