Re: [Qemu-devel] [PATCH] block: Fix -incoming with snapshot=on

2016-02-22 Thread Kevin Wolf
Am 19.02.2016 um 17:12 hat Paolo Bonzini geschrieben: > > > On 19/02/2016 16:52, Kevin Wolf wrote: > > The BDRV_O_INACTIVE flag should only be set for images explicitly opened > > by the user. snapshot=on needs to create a new qcow2 image and write > > some metadata to it. This is not a problem b

Re: [Qemu-devel] [PATCH] block: Fix -incoming with snapshot=on

2016-02-19 Thread Paolo Bonzini
On 19/02/2016 16:52, Kevin Wolf wrote: > The BDRV_O_INACTIVE flag should only be set for images explicitly opened > by the user. snapshot=on needs to create a new qcow2 image and write > some metadata to it. This is not a problem because it can't come from > the source, so there's no reason to ma

[Qemu-devel] [PATCH] block: Fix -incoming with snapshot=on

2016-02-19 Thread Kevin Wolf
The BDRV_O_INACTIVE flag should only be set for images explicitly opened by the user. snapshot=on needs to create a new qcow2 image and write some metadata to it. This is not a problem because it can't come from the source, so there's no reason to mark it as BDRV_O_INACTIVE, even though it is opene