Re: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-19 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 10:21:05PM +0200, Stefan Weil wrote: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil > --- > > Please note: I could only run limited tests with the new code > because ssh.c is currently not compiled in my w32/w64 env

Re: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-18 Thread Richard W.M. Jones
On Thu, Apr 18, 2013 at 10:21:05PM +0200, Stefan Weil wrote: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil ACK, this looks fine to me. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is '

[Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-18 Thread Stefan Weil
Now gcc will check whether format string and variable arguments match. Signed-off-by: Stefan Weil --- Please note: I could only run limited tests with the new code because ssh.c is currently not compiled in my w32/w64 environment. Regards, Stefan W. block/ssh.c |4 ++-- 1 file changed, 2