Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-20 Thread Vladimir Sementsov-Ogievskiy
20.11.2017 12:51, Vladimir Sementsov-Ogievskiy wrote: 17.11.2017 23:40, John Snow wrote: On 11/17/2017 01:25 PM, Kevin Wolf wrote: Am 17.11.2017 um 19:15 hat John Snow geschrieben: On 11/17/2017 10:01 AM, Max Reitz wrote: On 2017-11-17 13:30, Kevin Wolf wrote: Am 23.10.2017 um 11:29 hat Vl

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-20 Thread Vladimir Sementsov-Ogievskiy
17.11.2017 23:40, John Snow wrote: On 11/17/2017 01:25 PM, Kevin Wolf wrote: Am 17.11.2017 um 19:15 hat John Snow geschrieben: On 11/17/2017 10:01 AM, Max Reitz wrote: On 2017-11-17 13:30, Kevin Wolf wrote: Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: Snapshot-switc

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread John Snow
On 11/17/2017 01:25 PM, Kevin Wolf wrote: > Am 17.11.2017 um 19:15 hat John Snow geschrieben: >> >> >> On 11/17/2017 10:01 AM, Max Reitz wrote: >>> On 2017-11-17 13:30, Kevin Wolf wrote: Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Snapshot-switch actually chang

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Kevin Wolf
Am 17.11.2017 um 19:15 hat John Snow geschrieben: > > > On 11/17/2017 10:01 AM, Max Reitz wrote: > > On 2017-11-17 13:30, Kevin Wolf wrote: > >> Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>> Snapshot-switch actually changes active state of disk so it should > >>> refl

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread John Snow
On 11/17/2017 10:01 AM, Max Reitz wrote: > On 2017-11-17 13:30, Kevin Wolf wrote: >> Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> Snapshot-switch actually changes active state of disk so it should >>> reflect on dirty bitmaps. Otherwise next incremental backup using >>

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Max Reitz
On 2017-11-17 13:30, Kevin Wolf wrote: > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Snapshot-switch actually changes active state of disk so it should >> reflect on dirty bitmaps. Otherwise next incremental backup using >> these bitmaps will be invalid. >> >> Signed-off

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Kevin Wolf
Am 17.11.2017 um 13:58 hat Denis V. Lunev geschrieben: > On 11/17/2017 03:30 PM, Kevin Wolf wrote: > > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Snapshot-switch actually changes active state of disk so it should > >> reflect on dirty bitmaps. Otherwise next increment

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Denis V. Lunev
On 11/17/2017 04:42 PM, Kevin Wolf wrote: > Am 17.11.2017 um 13:58 hat Denis V. Lunev geschrieben: >> On 11/17/2017 03:30 PM, Kevin Wolf wrote: >>> Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: Snapshot-switch actually changes active state of disk so it should refle

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Denis V. Lunev
On 11/17/2017 03:30 PM, Kevin Wolf wrote: > Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Snapshot-switch actually changes active state of disk so it should >> reflect on dirty bitmaps. Otherwise next incremental backup using >> these bitmaps will be invalid. >> >> Signed-

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-17 Thread Kevin Wolf
Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > > Signed-off-by: Vladimir Sementsov-Ogievskiy We discus

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-14 Thread Max Reitz
On 2017-10-23 11:29, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snapsho

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-02 Thread John Snow
On 10/23/2017 05:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > Good call. I knew that snapshots weren't compatible, but this m

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-10-27 Thread Eric Blake
On 10/23/2017 11:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snap

[Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-10-23 Thread Vladimir Sementsov-Ogievskiy
Snapshot-switch actually changes active state of disk so it should reflect on dirty bitmaps. Otherwise next incremental backup using these bitmaps will be invalid. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/snapshot.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a