Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak

2014-12-12 Thread Stefan Hajnoczi
On Thu, Dec 04, 2014 at 02:34:11PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Variable local_err going out of scope > leaks the storage it points to. > > Cc: Markus Armbruster > Signed-off-by: Gonglei > --- > block/rbd.c | 8 > 1 file changed, 4 insertions(+), 4 deleti

Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak

2014-12-10 Thread Gonglei
On 2014/12/4 14:34, Gonglei (Arei) wrote: > From: Gonglei > > Variable local_err going out of scope > leaks the storage it points to. > > Cc: Markus Armbruster > Signed-off-by: Gonglei > --- > block/rbd.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Ping... > diff --g

Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak

2014-12-03 Thread Gonglei
On 2014/12/4 14:51, Amos Kong wrote: > 'local_err' was defined for collecting error insider qemu_opts_absorb_qdict(). > We should set error to 'errp', then the error can be passed to caller, > and free the memory in future. > > Reviewed-by: Amos Kong Thanks :) Regards, -Gonglei

Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak

2014-12-03 Thread Amos Kong
On Thu, Dec 04, 2014 at 02:34:11PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Variable local_err going out of scope > leaks the storage it points to. > > Cc: Markus Armbruster > Signed-off-by: Gonglei > --- > block/rbd.c | 8 > 1 file changed, 4 insertions(+), 4 deleti

[Qemu-devel] [PATCH] block/rbd: fix memory leak

2014-12-03 Thread arei.gonglei
From: Gonglei Variable local_err going out of scope leaks the storage it points to. Cc: Markus Armbruster Signed-off-by: Gonglei --- block/rbd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 5b5a64a..f3ab2dd 100644 --- a/block/rbd.