Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-24 Thread Paolo Bonzini
- Original Message - > From: "ronnie sahlberg" > To: "Paolo Bonzini" > Cc: "Roy Shterman" , "qemu-devel" > , "Peter Lieven" > Sent: Monday, August 22, 2016 10:35:03 PM > Subject: Re: [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU > > It is never too late. > > I can start

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-22 Thread ronnie sahlberg
It is never too late. I can start working on a patch to add "iser://" URL support to libiscsi right now. It should be a trivial change. I think I would prefer iser:// instead of iscsi+iser:// but it is not religiusly. Let me know if you rather want iscsi+iser. But you would still need some chang

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-06 Thread Roy Shterman
Hi, I checked my patch and found only warnings about long lines (over 80 characters), Splitting those lines will make the code much less verbose in my opinion. If you still think I should split those lines I will do it gladly. Other than that I couldn't find any coding style issue in my patch.

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Roy Shterman
On 8/1/2016 4:52 PM, Paolo Bonzini wrote: On 28/07/2016 10:45, Peter Lieven wrote: Furthermore I would suggest using LIBISCS_FEATURE_ISER and not the API version in the preprocessor commands. Actually I disagree with this suggestion. The new API could be used also if iSER is not used, can i

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Paolo Bonzini
On 28/07/2016 10:45, Peter Lieven wrote: > > Furthermore I would suggest using LIBISCS_FEATURE_ISER and not the API > version in the > preprocessor commands. Actually I disagree with this suggestion. The new API could be used also if iSER is not used, can it? Thanks, Paolo

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 12:02, Roy Shterman wrote: > iSER is a new transport layer supported in Libiscsi, > iSER provides a zero-copy RDMA capable interface that can > improve performance. > > New API is introduced in abstracion of the Libiscsi transport layer. > In order to use the new iSER transport, on

Re: [Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-07-28 Thread Peter Lieven
Am 27.07.2016 um 12:02 schrieb Roy Shterman: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi transport layer. In order to use the new iSER transport, one need t

[Qemu-devel] [PATCH] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-07-27 Thread Roy Shterman
iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API is introduced in abstracion of the Libiscsi transport layer. In order to use the new iSER transport, one need to add the ?iser option at the end of Libiscsi U