Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-23 Thread Matt Parker
On 22 August 2017 at 09:44, Peter Maydell wrote: > On 21 August 2017 at 22:13, Matt Parker wrote: >> intel-hda is still using the old_mmio accessors for io. >> This updates the device to use .read and .write accessors instead. > > Hi; thanks for this patch. > > It looks like you forgot to provide

Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-22 Thread Peter Maydell
On 21 August 2017 at 22:13, Matt Parker wrote: > intel-hda is still using the old_mmio accessors for io. > This updates the device to use .read and .write accessors instead. Hi; thanks for this patch. It looks like you forgot to provide your Signed-off-by: line; we can't accept patches without o

Re: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-21 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170821211320.7026-1-mtpa...@gmail.com Subject: [Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] audio: intel-hda: do not use old_mmio accesses

2017-08-21 Thread Matt Parker
intel-hda is still using the old_mmio accessors for io. This updates the device to use .read and .write accessors instead. --- hw/audio/intel-hda.c | 56 +--- 1 file changed, 9 insertions(+), 47 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/au