Re: [Qemu-devel] [PATCH] audio/hda: Fix migration

2018-07-24 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Fix outgoing migration which was crashing in > vmstate_hda_audio_stream_buf_needed, I think the problem > is that we have room for upto 4 streams in the array but only > use 2, when we come to try and

Re: [Qemu-devel] [PATCH] audio/hda: Fix migration

2018-07-24 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Fix outgoing migration which was crashing in > vmstate_hda_audio_stream_buf_needed, I think the problem > is that we have room for upto 4 streams in the array but only > use 2, when we come to try and save the state of the

Re: [Qemu-devel] [PATCH] audio/hda: Fix migration

2018-07-24 Thread Daniel P . Berrangé
On Tue, Jul 24, 2018 at 11:22:15AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Fix outgoing migration which was crashing in > vmstate_hda_audio_stream_buf_needed, I think the problem > is that we have room for upto 4 streams in the array but only > use 2, when

[Qemu-devel] [PATCH] audio/hda: Fix migration

2018-07-24 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Fix outgoing migration which was crashing in vmstate_hda_audio_stream_buf_needed, I think the problem is that we have room for upto 4 streams in the array but only use 2, when we come to try and save the state of the unused streams we hit st->state == NULL. Fixes: