Re: [Qemu-devel] [PATCH] arm_mptimer: Fix timer shutdown

2015-07-02 Thread Dmitry Osipenko
Hello Peter, thanks a lot for comment. 02.07.2015 12:27, Peter Maydell пишет: Thanks; this does look like a bug. This change will mean we call timer_del() even if the timer was already disabled, though, so I think it would be slightly better to rearrange the existing logic something like this:

Re: [Qemu-devel] [PATCH] arm_mptimer: Fix timer shutdown

2015-07-02 Thread Peter Maydell
On 1 July 2015 at 22:15, Dmitry Osipenko wrote: > Timer, running in periodic mode, can't be stopped or coming one-shot tick > won't be canceled because timer control code just doesn't handle timer > disabling. Fix it by checking enable bit and deleting timer if bit isn't set. > > Signed-off-by: Dm

[Qemu-devel] [PATCH] arm_mptimer: Fix timer shutdown

2015-07-01 Thread Dmitry Osipenko
Timer, running in periodic mode, can't be stopped or coming one-shot tick won't be canceled because timer control code just doesn't handle timer disabling. Fix it by checking enable bit and deleting timer if bit isn't set. Signed-off-by: Dmitry Osipenko --- hw/timer/arm_mptimer.c | 3 +++ 1 file