Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-17 Thread Pranith Kumar
On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini wrote: > > > On 16/06/2016 21:07, Richard Henderson wrote: >>> && ((addr >> 41) & 3) == 2 >>> -&& addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); >>> +&& addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1); > > What you

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-17 Thread Paolo Bonzini
On 16/06/2016 21:07, Richard Henderson wrote: >> && ((addr >> 41) & 3) == 2 >> -&& addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); >> +&& addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1); What you want here is + addr >> TARGET_VIRT_ADDR_SPACE_BITS

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-17 Thread Pranith Kumar
On Fri, Jun 17, 2016 at 2:09 PM, Richard Henderson wrote: > On 06/17/2016 11:07 AM, Pranith Kumar wrote: >> On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini wrote: >>> >>> >>> On 16/06/2016 21:07, Richard Henderson wrote: > && ((addr >> 41) & 3) == 2 > -&& addr >> T

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-17 Thread Richard Henderson
On 06/17/2016 11:07 AM, Pranith Kumar wrote: > On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini wrote: >> >> >> On 16/06/2016 21:07, Richard Henderson wrote: && ((addr >> 41) & 3) == 2 -&& addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63); +&& add

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-17 Thread Pranith Kumar
On Thu, Jun 16, 2016 at 8:43 PM, Laurent Vivier wrote: > > > Le 16/06/2016 à 21:15, Pranith Kumar a écrit : >> On Thu, Jun 16, 2016 at 3:07 PM, Richard Henderson wrote: >>> On 06/16/2016 11:56 AM, Pranith Kumar wrote: Using gcc 6.1 for alpha-linux-user target we see the following build

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-16 Thread Laurent Vivier
Le 16/06/2016 à 21:15, Pranith Kumar a écrit : > On Thu, Jun 16, 2016 at 3:07 PM, Richard Henderson wrote: >> On 06/16/2016 11:56 AM, Pranith Kumar wrote: >>> Using gcc 6.1 for alpha-linux-user target we see the following build >>> error: >>> >>> /mnt/devops/code/qemu/target-alpha/translate.c: I

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-16 Thread Pranith Kumar
On Thu, Jun 16, 2016 at 3:07 PM, Richard Henderson wrote: > On 06/16/2016 11:56 AM, Pranith Kumar wrote: >> Using gcc 6.1 for alpha-linux-user target we see the following build >> error: >> >> /mnt/devops/code/qemu/target-alpha/translate.c: In function ‘in_superpage’: >> /mnt/devops/code/qemu/targ

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-16 Thread Richard Henderson
On 06/16/2016 11:56 AM, Pranith Kumar wrote: > Using gcc 6.1 for alpha-linux-user target we see the following build > error: > > /mnt/devops/code/qemu/target-alpha/translate.c: In function ‘in_superpage’: > /mnt/devops/code/qemu/target-alpha/translate.c:454:52: error: self-comparison > always eva

[Qemu-devel] [PATCH] alpha: Fix build error for linux-user

2016-06-16 Thread Pranith Kumar
Using gcc 6.1 for alpha-linux-user target we see the following build error: /mnt/devops/code/qemu/target-alpha/translate.c: In function ‘in_superpage’: /mnt/devops/code/qemu/target-alpha/translate.c:454:52: error: self-comparison always evaluates to true [-Werror=tautological-compare]