Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 12:49 PM, Lin Ma wrote: Paolo Bonzini 11/12/12 7:27 PM >>> > > Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >>> > QEMU doesn't check if there are mac collisions when adding nics. >>> > It causes mac address collisions in guest if adding the nics which >>> > inc

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Lin Ma
>>> Paolo Bonzini 11/12/12 7:27 PM >>> Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >> > QEMU doesn't check if there are mac collisions when adding nics. >> > It causes mac address collisions in guest if adding the nics which >> > include existing physical address. >> > This patch fixes the

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Paolo Bonzini
Il 12/11/2012 12:18, Daniel P. Berrange ha scritto: >> > QEMU doesn't check if there are mac collisions when adding nics. >> > It causes mac address collisions in guest if adding the nics which >> > include existing physical address. >> > This patch fixes the issue. > I understand the issue, but ar

Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Daniel P. Berrange
On Mon, Nov 12, 2012 at 07:12:46PM +0800, Lin Ma wrote: > QEMU doesn't check if there are mac collisions when adding nics. > It causes mac address collisions in guest if adding the nics which > include existing physical address. > This patch fixes the issue. I understand the issue, but are there n

[Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add

2012-11-12 Thread Lin Ma
QEMU doesn't check if there are mac collisions when adding nics. It causes mac address collisions in guest if adding the nics which include existing physical address. This patch fixes the issue. Signed-off-by: Lin Ma --- hw/qdev-properties.c |9 + net.c| 28 +++