Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-09 Thread Alexander Graf
On 09.05.2011, at 09:43, Gerd Hoffmann wrote: > Hi, > >> Looking closer at file hw/usb-musb.c, I'd even recommend removing >> all 'inline' attributes there: > > I'll do that. > > /me wonders why the local test build worked just fine. Seems recent gcc > versions became pickier (running gcc 4

Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-09 Thread Gerd Hoffmann
Hi, Looking closer at file hw/usb-musb.c, I'd even recommend removing all 'inline' attributes there: I'll do that. /me wonders why the local test build worked just fine. Seems recent gcc versions became pickier (running gcc 4.4). cheers, Gerd

Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-08 Thread Stefan Weil
Am 08.05.2011 17:54, schrieb Stefan Weil: Am 08.05.2011 00:59, schrieb Alexander Graf: Today's git failed building for me. It looks like a mismatching function prototype definition. This patch fixes compilation of arm-softmmu for me. Signed-off-by: Alexander Graf --- hw/usb-musb.c | 2 +- 1 fi

Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-08 Thread Stefan Weil
Am 08.05.2011 00:59, schrieb Alexander Graf: Today's git failed building for me. It looks like a mismatching function prototype definition. This patch fixes compilation of arm-softmmu for me. Signed-off-by: Alexander Graf --- hw/usb-musb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-

Re: [Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-08 Thread Andreas Färber
Am 08.05.2011 um 00:59 schrieb Alexander Graf: Today's git failed building for me. It looks like a mismatching function prototype definition. This patch fixes compilation of arm-softmmu for me. Signed-off-by: Alexander Graf Yup, prototype was incorrectly introduced in 13a9a0d3e253e27274

[Qemu-devel] [PATCH] USB: Fix build breakage in musb

2011-05-07 Thread Alexander Graf
Today's git failed building for me. It looks like a mismatching function prototype definition. This patch fixes compilation of arm-softmmu for me. Signed-off-by: Alexander Graf --- hw/usb-musb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-musb.c b/hw/usb-mus