Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-26 Thread Yuanhan Liu
On Thu, Nov 26, 2015 at 06:52:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote: > > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > > > > > In case of live

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-26 Thread Michael S. Tsirkin
On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote: > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > > > In case of live migration several queues can be enabled and not only the > > first one. So in

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-25 Thread Yuanhan Liu
On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > In case of live migration several queues can be enabled and not only the > first one. So informing backend that only the first queue is enabled is > wrong. Revie

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-25 Thread Thibaut Collet
On Wed, Nov 25, 2015 at 1:42 PM, Michael S. Tsirkin wrote: > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > In case of live migration several queues can be enabled and not only the > first one. So informing backend that only the first queue is enabled is > wrong. > > Reported-by

[Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

2015-11-25 Thread Michael S. Tsirkin
This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. In case of live migration several queues can be enabled and not only the first one. So informing backend that only the first queue is enabled is wrong. Reported-by: Thibaut Collet Cc: Yuanhan Liu Signed-off-by: Michael S. Tsirkin --