Re: [Qemu-devel] [PATCH] Retrieve the correct TD byte when checking an ATR.

2015-01-19 Thread Jeremy White
>> The '40' should have been the second TD; instead >> the FF is used, incorrectly. > > The second TD? There is only one here, T0 = 0x95 & 0xf0 >> 4 = b1001 Yes, sorry, I should not have capitalized TD in my comment. The code uses the variable 'td' to hold the upper 4 bits of T0, and then, if pr

Re: [Qemu-devel] [PATCH] Retrieve the correct TD byte when checking an ATR.

2015-01-19 Thread Marc-André Lureau
On Mon, Jan 19, 2015 at 3:57 PM, Jeremy White wrote: > A physical smartcard with an ATR of > 3B 95 95 40 FF AE 01 0E 00 00 > was parsed incorrectly. > > The '40' should have been the second TD; instead > the FF is used, incorrectly. The second TD? There is only one here, T0 = 0x95 & 0xf0 >> 4 =

[Qemu-devel] [PATCH] Retrieve the correct TD byte when checking an ATR.

2015-01-19 Thread Jeremy White
A physical smartcard with an ATR of 3B 95 95 40 FF AE 01 0E 00 00 was parsed incorrectly. The '40' should have been the second TD; instead the FF is used, incorrectly. Signed-off-by: Jeremy White --- hw/usb/ccid-card-passthru.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --