Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Luiz Capitulino
On Tue, 14 Jun 2011 14:14:58 +0300 Avi Kivity wrote: > On 06/14/2011 01:56 PM, Jan Kiszka wrote: > > > > > > I believe it is not. But regardless, we shouldn't add more incorrect > > > behaviour. > > > > It depends on how the reset event is defined in QMP. As I see it, there > > is nothing stat

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Avi Kivity
On 06/14/2011 01:56 PM, Jan Kiszka wrote: > > I believe it is not. But regardless, we shouldn't add more incorrect > behaviour. It depends on how the reset event is defined in QMP. As I see it, there is nothing stated about reset reasons or sources. So emitting information about the actually

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Jan Kiszka
On 2011-06-14 12:50, Avi Kivity wrote: > On 06/14/2011 09:19 AM, Jan Kiszka wrote: >> On 2011-06-12 19:13, Avi Kivity wrote: >> > On 06/11/2011 12:05 PM, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> >> >> In case we load the vmstate during incoming migration, we start >> from a >> >> clean, d

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-14 Thread Avi Kivity
On 06/14/2011 09:19 AM, Jan Kiszka wrote: On 2011-06-12 19:13, Avi Kivity wrote: > On 06/11/2011 12:05 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> In case we load the vmstate during incoming migration, we start from a >> clean, default machine state as we went through system reset before.

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-13 Thread Jan Kiszka
On 2011-06-12 19:13, Avi Kivity wrote: > On 06/11/2011 12:05 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> In case we load the vmstate during incoming migration, we start from a >> clean, default machine state as we went through system reset before. But >> if we load from a snapshot, the machine

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-13 Thread Jan Kiszka
On 2011-06-12 19:42, Peter Maydell wrote: > On 11 June 2011 10:05, Jan Kiszka wrote: >> @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name) >> return -EINVAL; >> } >> >> +qemu_system_reset(); >> ret = qemu_loadvm_state(f); > > This means that if we're doing a load because

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-12 Thread Peter Maydell
On 11 June 2011 10:05, Jan Kiszka wrote: > @@ -2074,6 +2074,7 @@ int load_vmstate(const char *name) >         return -EINVAL; >     } > > +    qemu_system_reset(); >     ret = qemu_loadvm_state(f); This means that if we're doing a load because the user passed -loadvm on the command line we'll end

Re: [Qemu-devel] [PATCH] Reset system before loadvm

2011-06-12 Thread Avi Kivity
On 06/11/2011 12:05 PM, Jan Kiszka wrote: From: Jan Kiszka In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot, the machine can be in any state. That can cause troubles if loadi

[Qemu-devel] [PATCH] Reset system before loadvm

2011-06-11 Thread Jan Kiszka
From: Jan Kiszka In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot, the machine can be in any state. That can cause troubles if loading an older image which does not carry all