Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-08 Thread Avi Kivity
On 01/07/2012 07:44 PM, Blue Swirl wrote: > > Making the build faster (by killing libhw32/libhw64) would be a good > > justification for this type of change IMHO. > > The original reason was to avoid 64 bit arithmetic on 32 bit hosts. > Now that 128 bit arithmetic is used for memory API, it probabl

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-07 Thread Blue Swirl
On Wed, Jan 4, 2012 at 22:09, Anthony Liguori wrote: > On 01/04/2012 01:50 PM, Peter Maydell wrote: >> >> On 4 January 2012 19:32, Avi Kivity  wrote: >>> >>> The name 'Phys' conveys exactly the same information as >>> 'target_phys_addr_t': >>> >>>  - it has to be a physical address (no such thing

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-07 Thread Stefan Weil
Am 05.01.2012 01:24, schrieb Peter Maydell: On 5 January 2012 00:16, Anthony Liguori wrote: On 01/04/2012 05:33 PM, Peter Maydell wrote: A lot of the usage of target_phys_addr_t in hw/ is actually not handling addresses at all, but merely offsets into device IO regions (ie as parameters to dev

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Peter Maydell
On 5 January 2012 00:16, Anthony Liguori wrote: > On 01/04/2012 05:33 PM, Peter Maydell wrote: >> A lot of the usage of target_phys_addr_t in hw/ is actually not >> handling addresses at all, but merely offsets into device IO regions >> (ie as parameters to device read/write functions)... > > Exac

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Anthony Liguori
On 01/04/2012 05:33 PM, Peter Maydell wrote: On 4 January 2012 22:09, Anthony Liguori wrote: target_phys_addr_t should exist IMHO in the device model code. (I assume "should not" ?) Yes, sorry. I think it would be more useful to introduce a hw_addr, fix it at u64, make the device mode

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Peter Maydell
On 4 January 2012 22:09, Anthony Liguori wrote: > target_phys_addr_t should exist IMHO in the device model code. (I assume "should not" ?) > I think it > would be more useful to introduce a hw_addr, fix it at u64, make the device > model and memory API use that, and then make it so we didn't do

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Anthony Liguori
On 01/04/2012 01:50 PM, Peter Maydell wrote: On 4 January 2012 19:32, Avi Kivity wrote: The name 'Phys' conveys exactly the same information as 'target_phys_addr_t': - it has to be a physical address (no such thing as physical data) - it has to be a target address (qemu doesn't do host phy

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Avi Kivity
On 01/04/2012 09:50 PM, Peter Maydell wrote: > On 4 January 2012 19:32, Avi Kivity wrote: > > The name 'Phys' conveys exactly the same information as > > 'target_phys_addr_t': > > > > - it has to be a physical address (no such thing as physical data) > > - it has to be a target address (qemu do

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-04 Thread Peter Maydell
On 4 January 2012 19:32, Avi Kivity wrote: > The name 'Phys' conveys exactly the same information as 'target_phys_addr_t': > >  - it has to be a physical address (no such thing as physical data) >  - it has to be a target address (qemu doesn't do host physical addresses) >  - the fact that it's a