Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-16 Thread Alexander Graf
On 14.05.14 10:23, Peter Maydell wrote: On 14 May 2014 08:44, Kevin Wolf wrote: Am 13.05.2014 um 23:48 hat Eric Blake geschrieben: On 05/13/2014 03:11 PM, Mike Day wrote: Subject line could have used a [PATCHv2] designation to make it obvious this is a fixed version. But that doesn't affect

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-14 Thread Peter Maydell
On 14 May 2014 08:44, Kevin Wolf wrote: > Am 13.05.2014 um 23:48 hat Eric Blake geschrieben: >> On 05/13/2014 03:11 PM, Mike Day wrote: >> >> Subject line could have used a [PATCHv2] designation to make it obvious >> this is a fixed version. But that doesn't affect what goes into git. >> >> > g_s

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-14 Thread Kevin Wolf
Am 13.05.2014 um 23:48 hat Eric Blake geschrieben: > On 05/13/2014 03:11 PM, Mike Day wrote: > > Subject line could have used a [PATCHv2] designation to make it obvious > this is a fixed version. But that doesn't affect what goes into git. > > > g_sequence_lookup is not supported by glib < 2.28.

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Cornelia Huck
On Tue, 13 May 2014 17:11:06 -0400 Mike Day wrote: > g_sequence_lookup is not supported by glib < 2.28. The usage > of g_sequence_lookup is not essential in this context (it's a > safeguard against duplicate values in the help message). > Removing the call enables the build on all platforms and >

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Eric Blake
On 05/13/2014 03:11 PM, Mike Day wrote: Subject line could have used a [PATCHv2] designation to make it obvious this is a fixed version. But that doesn't affect what goes into git. > g_sequence_lookup is not supported by glib < 2.28. The usage > of g_sequence_lookup is not essential in this cont

[Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Mike Day
g_sequence_lookup is not supported by glib < 2.28. The usage of g_sequence_lookup is not essential in this context (it's a safeguard against duplicate values in the help message). Removing the call enables the build on all platforms and does not change the operation of the help function. Signed-of

Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Eric Blake
On 05/13/2014 12:34 PM, Mike Day wrote: > g_sequence_lookup is not supported by glib < 2.28. The usage > of g_sequence_lookup is not essential in this context (its a s/its/it's/ > safeguard against duplicate values in the help message). > Removing the call enables the build on all platforms and >

[Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function

2014-05-13 Thread Mike Day
g_sequence_lookup is not supported by glib < 2.28. The usage of g_sequence_lookup is not essential in this context (its a safeguard against duplicate values in the help message). Removing the call enables the build on all platforms and does not change the operation of the help function. Signed-off