Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-04 Thread Isaku Yamahata
On Mon, Apr 04, 2011 at 03:58:39PM +0400, Dmitry Eremin-Solenikov wrote: > On 4/3/11, Isaku Yamahata wrote: > > On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote: > >> On 4/2/11, Isaku Yamahata wrote: > >> >> Have you verified that all bus devices have been qdevified since t

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-04 Thread Dmitry Eremin-Solenikov
On 4/3/11, Isaku Yamahata wrote: > On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote: >> On 4/2/11, Isaku Yamahata wrote: >> >> Have you verified that all bus devices have been qdevified since this >> >> code has been added? I wouldn't bet it is the case. >> > >> > I think h

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-03 Thread Isaku Yamahata
On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote: > On 4/2/11, Isaku Yamahata wrote: > >> Have you verified that all bus devices have been qdevified since this > >> code has been added? I wouldn't bet it is the case. > > > > I think his analysis is valid. So how about the fo

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-02 Thread Dmitry Eremin-Solenikov
On 4/2/11, Isaku Yamahata wrote: >> Have you verified that all bus devices have been qdevified since this >> code has been added? I wouldn't bet it is the case. > > I think his analysis is valid. So how about the following patch. Could you please point me to an example of devices for which this c

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-01 Thread Isaku Yamahata
> Have you verified that all bus devices have been qdevified since this > code has been added? I wouldn't bet it is the case. I think his analysis is valid. So how about the following patch. >From ee27041a238d51247e30100d1909066978cd8858 Mon Sep 17 00:00:00 2001 Message-Id: From: Isaku Yamahata

Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-04-01 Thread Aurelien Jarno
On Mon, Feb 21, 2011 at 02:08:53AM +0300, Dmitry Eremin-Solenikov wrote: > Currently reset handler is registered for System bus twice: once during > bus creation and once in vl.c. Remove the second qemu_register_reset() > invocation. Also while we are at it, remove incorrect check at > qbus_create_

[Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-03-10 Thread Dmitry Eremin-Solenikov
Currently reset handler is registered for System bus twice: once during bus creation and once in vl.c. Remove the second qemu_register_reset() invocation. Also while we are at it, remove incorrect check at qbus_create_inplace(): when system bus is created, main_system_bus is NULL (as it's not yet c

[Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus

2011-02-20 Thread Dmitry Eremin-Solenikov
Currently reset handler is registered for System bus twice: once during bus creation and once in vl.c. Remove the second qemu_register_reset() invocation. Also while we are at it, remove incorrect check at qbus_create_inplace(): when system bus is created, main_system_bus is NULL (as it's not yet c