Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-04 Thread Edgar E. Iglesias
On Tue, Oct 04, 2016 at 06:53:20PM +0530, Rutuja Shah wrote: > Hi, > Allocating txbuf in struct Stream seems to be good. I can see other > pointers of struct Stream being allocated in xilinx_axidma_realize(), > but I am not able to find their deallocation point anywhere? Hi, Actually, since the a

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-04 Thread Rutuja Shah
Hi, Allocating txbuf in struct Stream seems to be good. I can see other pointers of struct Stream being allocated in xilinx_axidma_realize(), but I am not able to find their deallocation point anywhere? Regards Rutuja Shah On Tue, Oct 4, 2016 at 3:56 AM, Edgar E. Iglesias wrote: > On Mon, Oct 03

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Edgar E. Iglesias
On Mon, Oct 03, 2016 at 10:32:40PM +0530, Rutuja Shah wrote: > ++ stefan Sorry for the typo. > Regards > Rutuja Shah > > > On Mon, Oct 3, 2016 at 10:26 PM, wrote: > > From: Rutuja Shah > > > > This patch allocates memory for txbuf array on the heap rather than the > > stack. > > As a result,

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 18:56, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > This patch allocates memory for txbuf array on the heap rather than the stack. > As a result, the stack frame size is reduced. > > Signed-off-by: Rutuja Shah > --- > hw/dma/xilinx_axidma.c | 4 +++- > 1 file changed,

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Rutuja Shah
++ stefan Sorry for the typo. Regards Rutuja Shah On Mon, Oct 3, 2016 at 10:26 PM, wrote: > From: Rutuja Shah > > This patch allocates memory for txbuf array on the heap rather than the stack. > As a result, the stack frame size is reduced. > > Signed-off-by: Rutuja Shah > --- > hw/dma/xilin

[Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread rutu . shah . 26
From: Rutuja Shah This patch allocates memory for txbuf array on the heap rather than the stack. As a result, the stack frame size is reduced. Signed-off-by: Rutuja Shah --- hw/dma/xilinx_axidma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/xilinx_axidma.c b/h