Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-31 Thread Ed Swierk
On 1/31/07, Thiemo Seufer <[EMAIL PROTECTED]> wrote: It doesn't apply for current CVS. Could you please update the patch? I would also prefer to have enums instead of raw constants in all those case statements. Here you go. --Ed diff -BurN qemu-snapshot-2007-01-22_05.orig/hw/acpi.c qemu-snapsh

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-31 Thread Thiemo Seufer
Ed Swierk wrote: > Here's a revised patch with the mmap stuff removed. I'll refine the > persistence support, but in the meantime the EEPROM device is usable > even if it forgets its contents when qemu exits. It doesn't apply for current CVS. Could you please update the patch? I would also prefer

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-24 Thread Fabrice Bellard
Ed Swierk wrote: Here's a revised patch with the mmap stuff removed. I'll refine the persistence support, but in the meantime the EEPROM device is usable even if it forgets its contents when qemu exits. The patch is OK now. Fabrice. ___ Qemu-devel

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-23 Thread Ed Swierk
Windows 2000 boots and PC Wizard 2007 displays the following information under the Mainboard category: > SMBus/i2c Bus : Yes >> General Information Device : 82371AB/EB/MB PIIX4/E/M Power Management Controller Revision : 0 Frequency : 16 KHz Address : 0xB100 >> Device

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-23 Thread Ed Swierk
Here's a revised patch with the mmap stuff removed. I'll refine the persistence support, but in the meantime the EEPROM device is usable even if it forgets its contents when qemu exits. --Ed Index: qemu-0.8.2/hw/acpi.c === --- qemu-0

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-23 Thread Ed Swierk
On 1/23/07, Fabrice Bellard <[EMAIL PROTECTED]> wrote: OK, but avoid using mmap() in the device code. Moreover, files in the BIOS directory are not writable. OK. Would it be better to do the following: - add a command-line option -seeprom that sets the file to use as backing store for the smbu

Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-23 Thread Fabrice Bellard
Ed Swierk wrote: The attached patch adds SMBus host support to the emulated PIIX4 power management device (acpi.c), and adds an emulated serial EEPROM device accessible via the SMBus interface. I tried to follow the Intel 82371AB spec for the SMBus support; the interface should be generic enough

[Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

2007-01-23 Thread Ed Swierk
The attached patch adds SMBus host support to the emulated PIIX4 power management device (acpi.c), and adds an emulated serial EEPROM device accessible via the SMBus interface. I tried to follow the Intel 82371AB spec for the SMBus support; the interface should be generic enough to implement a va