Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-15 Thread Daniel P. Berrange
On Wed, Mar 15, 2017 at 12:13:58PM +0800, Chao Fan wrote: > On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: > >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: > >> Chao Fan wrote: > >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. > >> > It's

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >> Chao Fan wrote: >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> > It's also better for other tools to determine the cpu throttle >> > valu

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 09:54:34AM -0500, Eric Blake wrote: >On 03/14/2017 05:27 AM, Chao Fan wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in different architecture. >> >> Signed-off-by: Chao F

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Eric Blake
On 03/14/2017 05:27 AM, Chao Fan wrote: > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. > It's also better for other tools to determine the cpu throttle > value in different architecture. > > Signed-off-by: Chao Fan > Signed-off-by: Li Zhijian > --- In addition to the (good)

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >Chao Fan wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in different architecture. >> >> Signed-off-by: Chao Fan >> Signed-off-by:

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >> Chao Fan wrote: >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> > It's also better for other tools to determine the cpu throttle >> > valu

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Daniel P. Berrange
On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: > Chao Fan wrote: > > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. > > It's also better for other tools to determine the cpu throttle > > value in different architecture. > > > > Signed-off-by: Chao Fan > > Signed-

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Juan Quintela
Chao Fan wrote: > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. > It's also better for other tools to determine the cpu throttle > value in different architecture. > > Signed-off-by: Chao Fan > Signed-off-by: Li Zhijian I agree with Daniel here, you can't change the meaning o

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 10:45:16AM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 06:27:47PM +0800, Chao Fan wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in different architecture. >>

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Daniel P. Berrange
On Tue, Mar 14, 2017 at 06:27:47PM +0800, Chao Fan wrote: > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. > It's also better for other tools to determine the cpu throttle > value in different architecture. > > Signed-off-by: Chao Fan > Signed-off-by: Li Zhijian > --- > hmp.c

[Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. It's also better for other tools to determine the cpu throttle value in different architecture. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian --- hmp.c | 6 +++--- migration/migration.c | 2 +- qapi-schema.json