Re: [Qemu-devel] [PATCH] Monitor: Fix command execution regression

2010-01-28 Thread Blue Swirl
Thanks, applied. On Wed, Jan 27, 2010 at 8:01 PM, Luiz Capitulino wrote: > > Function is_async_return() added by commit 940cc30d0d4 assumes > that 'data', which is returned by handlers, is always a QDict. > > This is not true, as QLists can also be returned, in this case > we'll get a segfault.

[Qemu-devel] [PATCH] Monitor: Fix command execution regression

2010-01-27 Thread Luiz Capitulino
Function is_async_return() added by commit 940cc30d0d4 assumes that 'data', which is returned by handlers, is always a QDict. This is not true, as QLists can also be returned, in this case we'll get a segfault. Fix that by checking if 'data' is a QDict. Signed-off-by: Luiz Capitulino --- moni