Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Paolo Bonzini
> > > When I was inspecting the icon using the genie feature of Mac OS X's > > > dock, the icon looked very sharp at full size, so I didn't see a > > > problem with it. What size do you have in mind? > > > > I was thinking of 16x16, 32x32, 48x48 and 128x128. > > What advantages do you think this

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 12:56 PM, Paolo Bonzini wrote: > > > On 20/02/2015 18:32, Programmingkid wrote: >>> Ok, so I'll apply v3 to my tree as soon as I get a Tested-by. >>> Please take a look into providing a .rsrc file with larger-sized >>> icons (I think you can add more than one to a single .rs

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 18:32, Programmingkid wrote: >> Ok, so I'll apply v3 to my tree as soon as I get a Tested-by. >> Please take a look into providing a .rsrc file with larger-sized >> icons (I think you can add more than one to a single .rsrc file?) >> and, when you do that, document in pc-bios/README

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 12:05 PM, Paolo Bonzini wrote: > > > On 20/02/2015 17:54, Programmingkid wrote: >>> I suspect the Windows icon is not a great match for Mac OS X which likes >>> to have big sizes (48x48 or 128x128). >> >> Definitely true. >> >>> If you want to generate the .rsrc >>> file a

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 17:54, Programmingkid wrote: >> I suspect the Windows icon is not a great match for Mac OS X which likes >> to have big sizes (48x48 or 128x128). > > Definitely true. > >> If you want to generate the .rsrc >> file automatically, the right source probably would be the .svg file, >

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 7:36 AM, Paolo Bonzini wrote: > > > On 20/02/2015 13:18, Peter Maydell wrote: >> Why not just use the sips --out option to specify a different >> output file? That way we automatically put the current icon >> into the executable, and don't have to update a hand-created >> qe

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread François Revol
On 20/02/2015 13:36, Paolo Bonzini wrote: > > > On 20/02/2015 13:18, Peter Maydell wrote: >> Why not just use the sips --out option to specify a different >> output file? That way we automatically put the current icon >> into the executable, and don't have to update a hand-created >> qemu.rsrc fi

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 13:18, Peter Maydell wrote: > Why not just use the sips --out option to specify a different > output file? That way we automatically put the current icon > into the executable, and don't have to update a hand-created > qemu.rsrc file in git if we change the icon in future (and I > b

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Peter Maydell
On 19 February 2015 at 18:56, Paolo Bonzini wrote: > > > On 18/02/2015 22:09, Programmingkid wrote: >> + # Take an image and make the image its own icon: >> + sips -i ../pc-bios/qemu-nsis.ico >> + # Extract the icon to its own resource file: >> + DeRez -only icns ../pc-bios/qemu-ns

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-19 Thread Programmingkid
On Feb 19, 2015, at 4:56 AM, Paolo Bonzini wrote: > > > On 18/02/2015 22:09, Programmingkid wrote: >> +# Take an image and make the image its own icon: >> +sips -i ../pc-bios/qemu-nsis.ico >> +# Extract the icon to its own resource file: >> +DeRez -only icns ../pc-bios/qemu-nsis

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-19 Thread Paolo Bonzini
On 18/02/2015 22:09, Programmingkid wrote: > + # Take an image and make the image its own icon: > + sips -i ../pc-bios/qemu-nsis.ico > + # Extract the icon to its own resource file: > + DeRez -only icns ../pc-bios/qemu-nsis.ico > tmpicns.rsrc IIUC sips modifies ../pc-bios/qemu-ns

[Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-18 Thread Programmingkid
This patch adds the instruction to have the build commands give QEMU an icon. This code runs on Mac OS X. Signed-off-by: John Arbuckle --- Makefile.target | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) mode change 100644 => 100755 Makefile.target diff --git