Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-13 Thread Paolo Bonzini
On 13/02/19 08:45, Markus Armbruster wrote: > * If it doesn't, "default" / "imply" supply the value if condition is > met > > * What about contradictions between "default" / "imply"? We would avoid those by forbidding "default n", then "imply" would also be just another "default y". I'm quite

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 12/02/19 10:08, Markus Armbruster wrote: >> Please wrap your lines at column 70 or so. Humans tend to have trouble >> following long lines with their eyes (I sure do). Typographic manuals >> suggest to limit columns to roughly 60 characters for exactly that >> reason[

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 11/02/19 18:17, Cornelia Huck wrote: >> + >> +This domain-specific language is based on the Kconfig language that >> originated in the >> +Linux kernel, though it was heavily simplified and the handling of >> dependencies is >> +stricter in QEMU. >> + >> +Unlike Linux, there is no user interfa

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 12/02/19 10:13, Thomas Huth wrote: >> +Unlike Linux, there is no user interface to edit the configuration, which >> is instead >> +specified in per-target files under the ``default-configs/`` directory of >> the >> +QEMU source tree. This is because, unlike Linux, configuration and >> depend

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Paolo Bonzini
On 12/02/19 10:08, Markus Armbruster wrote: > Please wrap your lines at column 70 or so. Humans tend to have trouble > following long lines with their eyes (I sure do). Typographic manuals > suggest to limit columns to roughly 60 characters for exactly that > reason[*]. Yup, fixed in v2. >> +Ea

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Markus Armbruster
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst > > diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst > new file mode

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-12 Thread Thomas Huth
On 2019-02-11 17:38, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst Thanks for writing this up - that's a really helpful text! >

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Stefan Hajnoczi
On Mon, Feb 11, 2019 at 05:38:29PM +0100, Paolo Bonzini wrote: > +The Kconfig language > + > + > +Kconfig defines configurable components in files named ``hw/*/Kconfig``. > +Note that configurable components are _not_ visible in C code as > preprocessor symbols; > +they are onl

Re: [Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Cornelia Huck
On Mon, 11 Feb 2019 17:38:29 +0100 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/devel/kconfig.rst | 284 + > 1 file changed, 284 insertions(+) > create mode 100644 docs/devel/kconfig.rst > > diff --git a/docs/devel/kconfig.rst b/docs

[Qemu-devel] [PATCH] Kconfig: add documentation

2019-02-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/kconfig.rst | 284 + 1 file changed, 284 insertions(+) create mode 100644 docs/devel/kconfig.rst diff --git a/docs/devel/kconfig.rst b/docs/devel/kconfig.rst new file mode 100644 index 00..b653c43b12 ---