Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Liu, Jinsong
>> >> My question is, which kvm_get_msrs/kvm_put_msrs routine be used by >> live migration, the routine in target-i386/kvm.c, or in >> kvm/libkvm/libkvm-x86.c? They both have ioctl >> KVM_GET_MSR_INDEX_LIST/ KVM_GET_MSRS/ KVM_SET_MSRS, but I'm not >> clear their purpose/usage difference. > >

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Marcelo Tosatti
On Sat, Sep 10, 2011 at 02:11:36AM +0800, Liu, Jinsong wrote: > Marcelo Tosatti wrote: > > On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote: > > --- a/arch/x86/include/asm/msr-index.h > > +++ b/arch/x86/include/asm/msr-index.h > > @@ -229,6 +229,8 @@ > > #define MSR_IA3

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Liu, Jinsong
Marcelo Tosatti wrote: > On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote: > --- a/arch/x86/include/asm/msr-index.h > +++ b/arch/x86/include/asm/msr-index.h > @@ -229,6 +229,8 @@ > #define MSR_IA32_APICBASE_ENABLE (1<<11) > #define MSR_IA32_APICBASE_BASE

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Liu, Jinsong
Marcelo Tosatti wrote: > On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote: > --- a/arch/x86/include/asm/msr-index.h > +++ b/arch/x86/include/asm/msr-index.h > @@ -229,6 +229,8 @@ > #define MSR_IA32_APICBASE_ENABLE (1<<11) > #define MSR_IA32_APICBASE_BASE

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-09 Thread Marcelo Tosatti
On Fri, Sep 09, 2011 at 01:12:51AM +0800, Liu, Jinsong wrote: > >>> --- a/arch/x86/include/asm/msr-index.h > >>> +++ b/arch/x86/include/asm/msr-index.h > >>> @@ -229,6 +229,8 @@ > >>> #define MSR_IA32_APICBASE_ENABLE (1<<11) > >>> #define MSR_IA32_APICBASE_BASE (0xf<<12) > >>> > >>

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-08 Thread Liu, Jinsong
>>> --- a/arch/x86/include/asm/msr-index.h >>> +++ b/arch/x86/include/asm/msr-index.h >>> @@ -229,6 +229,8 @@ >>> #define MSR_IA32_APICBASE_ENABLE (1<<11) >>> #define MSR_IA32_APICBASE_BASE (0xf<<12) >>> >>> +#define MSR_IA32_TSCDEADLINE 0x06e0 >>> + >>> #def

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Liu, Jinsong
Avi Kivity wrote: > On 09/07/2011 07:45 PM, Liu, Jinsong wrote: >> Avi Kivity wrote: --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -229,6 +229,8 @@ #define MSR_IA32_APICBASE_ENABLE(1<<11) #define MSR_IA32_APICBASE_BA

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Avi Kivity
On 09/07/2011 07:45 PM, Liu, Jinsong wrote: Avi Kivity wrote: >> >> --- a/arch/x86/include/asm/msr-index.h >> +++ b/arch/x86/include/asm/msr-index.h >> @@ -229,6 +229,8 @@ >>#define MSR_IA32_APICBASE_ENABLE(1<<11) >>#define MSR_IA32_APICBASE_BASE (0xf<<12) >> >> +

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-07 Thread Liu, Jinsong
Avi Kivity wrote: >> >> --- a/arch/x86/include/asm/msr-index.h >> +++ b/arch/x86/include/asm/msr-index.h >> @@ -229,6 +229,8 @@ >> #define MSR_IA32_APICBASE_ENABLE (1<<11) >> #define MSR_IA32_APICBASE_BASE (0xf<<12) >> >> +#define MSR_IA32_TSCDEADLINE0x06

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-06 Thread Avi Kivity
On 09/06/2011 02:18 PM, Liu, Jinsong wrote: >>struct x86_instruction_info *info, >>enum x86_intercept_stage stage); >> + u64 (*guest_to_host_tsc)(u64 guest_tsc); >>}; > > Please put this near the other tsc functions. Add a comment > expl

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-06 Thread Liu, Jinsong
Marcelo Tosatti wrote: >>> --- a/arch/x86/include/asm/msr-index.h >>> +++ b/arch/x86/include/asm/msr-index.h >>> @@ -229,6 +229,8 @@ >>> #define MSR_IA32_APICBASE_ENABLE (1<<11) >>> #define MSR_IA32_APICBASE_BASE (0xf<<12) >>> >>> +#define MSR_IA32_TSCDEADLINE 0x0

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-06 Thread Liu, Jinsong
Thanks Avi, Marcelo, Kevin for comments, sorry for late reply (just come back from vacation). Avi Kivity wrote: > On 08/17/2011 07:19 AM, Liu, Jinsong wrote: >> From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 >> 2001 >> From: Liu, Jinsong >> Date: Wed, 17 Aug 2011 11:36:28 +0

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-28 Thread Tian, Kevin
> From: Marcelo Tosatti > Sent: Tuesday, August 23, 2011 6:47 PM > > > >+ if (!apic->lapic_timer.tscdeadline) > > >+ return; > > >+ > > >+ tsc_target = kvm_x86_ops-> > > >+ guest_to_host_tsc(apic->lapic_timer.tscdeadline); > > >+ rdtscll

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-23 Thread Marcelo Tosatti
On Mon, Aug 22, 2011 at 12:18:49PM +0300, Avi Kivity wrote: > On 08/17/2011 07:19 AM, Liu, Jinsong wrote: > > From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 > >From: Liu, Jinsong > >Date: Wed, 17 Aug 2011 11:36:28 +0800 > >Subject: [PATCH] KVM: emulate lapic tsc deadline tim

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-22 Thread Avi Kivity
On 08/17/2011 07:19 AM, Liu, Jinsong wrote: From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Wed, 17 Aug 2011 11:36:28 +0800 Subject: [PATCH] KVM: emulate lapic tsc deadline timer for hvm kvm doesn't have hvm. This patch emulate lapic tsc deadli

[Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-08-16 Thread Liu, Jinsong
>From a9670ddff84080c56183e2d678189e100f891174 Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Wed, 17 Aug 2011 11:36:28 +0800 Subject: [PATCH] KVM: emulate lapic tsc deadline timer for hvm This patch emulate lapic tsc deadline timer for hvm: Enumerate tsc deadline timer capacibility by CPUID;