Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-14 Thread Peter Maydell
On 14 December 2011 09:55, Alex Rozenman wrote: > Thank you for your comments. I'll submit a new patch. I am aware about > architertural differences b/w v6m and v7m, but many of them is less > relevant for the existing QEMU code (pririty bits for example). My concern really is that at the moment

Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-14 Thread Alex Rozenman
Hi Peter, Thank you for your comments. I'll submit a new patch. I am aware about architertural differences b/w v6m and v7m, but many of them is less relevant for the existing QEMU code (pririty bits for example). Alex On Tue, 2011-12-13 at 18:05 +, Peter Maydell wrote: > On 13 December 2011

Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-13 Thread Peter Maydell
On 13 December 2011 18:11, Andreas Färber wrote: > Please rebase against Peter's target-arm branch: > > http://git.linaro.org/gitweb?p=people/pmaydell/qemu-arm.git;a=shortlog;h=refs/heads/target-arm.next Note that this .next branch rebases, so treat it with the appropriate degree of caution. (I'

Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-13 Thread Richard Henderson
On 12/13/2011 09:44 AM, Alex Rozenman wrote: > +if (IS_V6M(env)) > +goto illegal_op; Also run your patch through scripts/checkpatch.pl. Which should have told you that you need braces here and elsewhere. r~

Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-13 Thread Andreas Färber
Hi, Am 13.12.2011 18:44, schrieb Alex Rozenman: > Please review / discuss / push the attched patch. It adds initial > support for V6-M for ARM and Cortex-M0. Please send this as an inline patch (git send-email) and cc Peter. Some comments: Please rebase against Peter's target-arm branch: http:

Re: [Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-13 Thread Peter Maydell
On 13 December 2011 17:44, Alex Rozenman wrote: > Please review / discuss / push the attched patch. It adds initial support > for V6-M for ARM and Cortex-M0. Please don't submit patches as attachments (see http://wiki.qemu.org/Contribute/SubmitAPatch for other guidelines). This patch is pretty o

[Qemu-devel] [PATCH] Initial support for ARM V6-M

2011-12-13 Thread Alex Rozenman
Hi, Please review / discuss / push the attched patch. It adds initial support for V6-M for ARM and Cortex-M0. Best regards, Alex Rozenman >From ff09b4ef970cde304c170c6e0a7678d2486b63e6 Mon Sep 17 00:00:00 2001 From: Alex Rozenman Date: Tue, 13 Dec 2011 19:28:39 +0200 Subject: [PATCH] Initial su