Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-09 Thread Valentin Manea
Hi Kevin On 2014-09-09 11:58, Kevin Wolf wrote: > Thanks, applied to the block branch. Thanks a lot > Please make sure that your patch isn't corrupted by your mail client, > like by this line wrap. I had to manually fix the patch before I could > apply it. For larger patches, I would simply have

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-09 Thread Kevin Wolf
Am 31.08.2014 um 10:32 hat Valentin Manea geschrieben: > > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian systems(eg OpenRisc).

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Peter Maydell
On 8 September 2014 10:07, Stefan Hajnoczi wrote: > This patch changes the semantics of the sh4eb target (with the r2d > machine type), where the mmio-ide registers currently don't need > byteswapping. > > I guess a real big-endian SH4 with MMIO IDE *should* byteswap but want > to double-check. >

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Michael Tokarev
08.09.2014 13:07, Stefan Hajnoczi wrote: > This patch changes the semantics of the sh4eb target (with the r2d > machine type), where the mmio-ide registers currently don't need > byteswapping. > > I guess a real big-endian SH4 with MMIO IDE *should* byteswap but want > to double-check. > > Does

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 08/09/2014 11:07, Stefan Hajnoczi ha scritto: > This patch changes the semantics of the sh4eb target (with the r2d > machine type), where the mmio-ide registers currently don't need > byteswapping. > > I guess a real big-endian SH4 with MMIO IDE

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Stefan Hajnoczi
On Sun, Aug 31, 2014 at 11:32:08AM +0300, Valentin Manea wrote: > > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian systems(eg Op

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-08 Thread Stefan Hajnoczi
On Sun, Sep 07, 2014 at 10:07:10PM +0300, Valentin Manea wrote: > Did anybody get the chance to review this patch? > It would be quite nice to integrate it before all the other openrisc > changes, to get > the IDE working also. Resending a patch as a reply in an existing thread increases the

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-09-07 Thread Valentin Manea
Hi, Did anybody get the chance to review this patch? It would be quite nice to integrate it before all the other openrisc changes, to get the IDE working also. Thanks, Valentin On 2014-08-31 11:32, Valentin Manea wrote: > > Set the IDE MMIO memory type to little endian. The ATA specs identi

[Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-31 Thread Valentin Manea
Set the IDE MMIO memory type to little endian. The ATA specs identify words part of the control commands encoded as little endian. While this has no impact on little endian systems, it's required for big endian systems(eg OpenRisc). Signed-off-by: Valentin Manea --- hw/ide/mmio.c | 4 ++-- 1 fi

Re: [Qemu-devel] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-22 Thread Peter Maydell
You forgot to cc qemu-devel... On 22 August 2014 09:52, Valentin Manea wrote: > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian