Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-29 Thread Markus Armbruster
Cao jin writes: > On 11/27/2015 10:22 PM, Markus Armbruster wrote: >> Cao jin writes: >> >>> Hi, Markus >>> >>> On 11/24/2015 06:08 PM, Markus Armbruster wrote: > [...] >>> >>> and this will cover to output to the monitor, right? >> >> The device still implements the old PCIDeviceClass.init() in

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-27 Thread Cao jin
On 11/27/2015 10:22 PM, Markus Armbruster wrote: Cao jin writes: Hi, Markus On 11/24/2015 06:08 PM, Markus Armbruster wrote: [...] and this will cover to output to the monitor, right? The device still implements the old PCIDeviceClass.init() instead of the new .realize(). All devices n

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-27 Thread Markus Armbruster
Cao jin writes: > Hi, Markus > > On 11/24/2015 06:08 PM, Markus Armbruster wrote: >> Cao jin writes: >> >>> detailed error info could show user about how to use it. >>> >>> Signed-off-by: Cao jin >>> --- >>> hw/pci-bridge/xio3130_downstream.c | 5 + >>> 1 file changed, 5 insertions(+) >>

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-27 Thread Cao jin
Hi, Markus On 11/24/2015 06:08 PM, Markus Armbruster wrote: Cao jin writes: detailed error info could show user about how to use it. Signed-off-by: Cao jin --- hw/pci-bridge/xio3130_downstream.c | 5 + 1 file changed, 5 insertions(+) When I learned to use root/upstream/downstream po

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-24 Thread Cao jin
Hi Markus On 11/24/2015 06:08 PM, Markus Armbruster wrote: Cao jin writes: detailed error info could show user about how to use it. Signed-off-by: Cao jin --- hw/pci-bridge/xio3130_downstream.c | 5 + 1 file changed, 5 insertions(+) When I learned to use root/upstream/downstream por

Re: [Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-24 Thread Markus Armbruster
Cao jin writes: > detailed error info could show user about how to use it. > > Signed-off-by: Cao jin > --- > hw/pci-bridge/xio3130_downstream.c | 5 + > 1 file changed, 5 insertions(+) > > When I learned to use root/upstream/downstream port like this: > qemu-system-x86_64 -M q35 -device io

[Qemu-devel] [PATCH] Give detailed info when pcie downstream port init failed

2015-11-24 Thread Cao jin
detailed error info could show user about how to use it. Signed-off-by: Cao jin --- hw/pci-bridge/xio3130_downstream.c | 5 + 1 file changed, 5 insertions(+) When I learned to use root/upstream/downstream port like this: qemu-system-x86_64 -M q35 -device ioh3420,bus=pcie.0,id=br1 -device x