Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Push zero'd pages into the XBZRLE cache > > A page that was cached by XBZRLE, zero'd and then XBZRLE'd again > > was being compared against a stale cache value >

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-18 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Push zero'd pages into the XBZRLE cache > A page that was cached by XBZRLE, zero'd and then XBZRLE'd again > was being compared against a stale cache value > > Don't use 'qemu_put_buffer_async' to put pages from th

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Orit Wasserman
On 02/13/2014 09:44 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Push zero'd pages into the XBZRLE cache A page that was cached by XBZRLE, zero'd and then XBZRLE'd again was being compared against a stale cache value Don't use 'qemu_put_buffer_async' to put

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Gonglei (Arei)
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, February 14, 2014 5:35 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; owass...@redhat.com; quint...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] Fix two XBZRLE

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: > > Best regards, > -Gonglei > > > > } else if (!ram_bulk_stage && migrate_use_xbzrle()) { > > -current_addr = block->offset + offset; > > bytes_sent = save_xbzrle_page(f, p, current_addr, block, >

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Gonglei (Arei)
gt; To: qemu-devel@nongnu.org > Cc: owass...@redhat.com; quint...@redhat.com > Subject: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues > > From: "Dr. David Alan Gilbert" > > Push zero'd pages into the XBZRLE cache > A page that was cached by XBZRLE, zero'

[Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Push zero'd pages into the XBZRLE cache A page that was cached by XBZRLE, zero'd and then XBZRLE'd again was being compared against a stale cache value Don't use 'qemu_put_buffer_async' to put pages from the XBZRLE cache Since the cache might change bef