Re: [Qemu-devel] [PATCH] Fix qapi code generation fix

2012-01-12 Thread Anthony Liguori
On 12/28/2011 04:26 AM, Avi Kivity wrote: The fixes to qapi code generation had multiple bugs: - the Null class used to drop output was missing some methods - in some scripts it was never instantiated, leading to a None return, which is missing even more methods - the --source and --header opt

Re: [Qemu-devel] [PATCH] Fix qapi code generation fix

2012-01-12 Thread Avi Kivity
On 12/28/2011 12:26 PM, Avi Kivity wrote: > The fixes to qapi code generation had multiple bugs: > - the Null class used to drop output was missing some methods > - in some scripts it was never instantiated, leading to a None return, > which is missing even more methods > - the --source and --hea

[Qemu-devel] [PATCH] Fix qapi code generation fix

2011-12-28 Thread Avi Kivity
The fixes to qapi code generation had multiple bugs: - the Null class used to drop output was missing some methods - in some scripts it was never instantiated, leading to a None return, which is missing even more methods - the --source and --header options were swapped Luckily, all those bugs we