On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote:
> The fix looks fine, but the resulting code is probably over
> engineered... What about:
>
> s->enable = (value & 9) == 1;
>
> ?
Looks OK to me.
Regards
Vasily
On Mon, Feb 14, 2011 at 06:59:10PM +0200, Vasily Khoruzhick wrote:
> RST bit is (1 << 3) bit, not (1 << 2), fix condition
> that enables i2s if ENB is set and RST is not set.
>
> Signed-off-by: Vasily Khoruzhick
> ---
> hw/pxa2xx.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
On Sun, Feb 20, 2011 at 08:39:20PM +0200, Vasily Khoruzhick wrote:
> On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote:
>
> > The fix looks fine, but the resulting code is probably over
> > engineered... What about:
> >
> > s->enable = (value & 9) == 1;
> >
> > ?
>
> Looks OK to
RST bit is (1 << 3) bit, not (1 << 2), fix condition
that enables i2s if ENB is set and RST is not set.
Signed-off-by: Vasily Khoruzhick
---
hw/pxa2xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c
index d966846..68b67ae 100644
--- a/hw/pxa2
