Re: [Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Kevin Wolf
Am 08.09.2014 um 16:40 hat Xiaodong Gong geschrieben: > From: Xiaodong Gong > > cpu_to_be32() is wrong since vhd_type is an enum constant > (just a regular CPU-endian integer). > > Signed-off-by: Xiaodong Gong Thanks, this one is perfect. :-) Applied to the block branch. Kevin

[Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Xiaodong Gong
From: Xiaodong Gong cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by: Xiaodong Gong --- block/vpc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 055efc4..c024b4c 100644 --

Re: [Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-08 Thread Kevin Wolf
Am 05.09.2014 um 20:40 hat 21G geschrieben: > cpu_to_be32() is wrong since vhd_type is an enum constant > (just a regular CPU-endian integer). > > Signed-off-by: Xiaodong Gong Please use 'git send-email' to send patches. Neither 'git am' nor 'patch' can seem to apply this patch (firstly because

[Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-05 Thread 21G
cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by: Xiaodong Gong --- block/vpc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 055efc4..c024b4c 100644 --- a/block/vpc.c +++ b/

Re: [Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-05 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 10:43:58PM +0800, Gordon Gong wrote: > From fd3f0fd9c53d7782d4d835597c8a07b897bec3d0 Mon Sep 17 00:00:00 2001 > > From: Xiaodong Gong > > Date: Sat, 30 Aug 2014 03:17:03 +0800 > > Subject: Fix improper usage of cpu_to_be32 in vpc > > > > cpu_to_be32() is wrong since v

[Qemu-devel] [PATCH] Fix improper usage of cpu_to_be32 in vpc

2014-09-04 Thread Gordon Gong
>From fd3f0fd9c53d7782d4d835597c8a07b897bec3d0 Mon Sep 17 00:00:00 2001 From: Xiaodong Gong Date: Sat, 30 Aug 2014 03:17:03 +0800 Subject: Fix improper usage of cpu_to_be32 in vpc cpu_to_be32() is wrong since vhd_type is an enum constant (just a regular CPU-endian integer). Signed-off-by