Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-26 Thread Gerd Hoffmann
Hi, > What are the required semantics for update/switch/refresh? > These don't seem to be documented. Can we validly make > those be asychronous, or does the midlayer require that > the operation has completed and been reflected onscreen > before the update/switch/refresh callback returns ? re

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-25 Thread Peter Maydell
On Thu, 22 Nov 2018 at 07:32, Gerd Hoffmann wrote: > > Hi, > > > Something somewhere in this call chain should have taken > > the iothread lock, I assume, but I'm not sure where. > > > > Gerd -- what are the rules of the UI subsystem regarding > > multiple threads, and what threads are allowed t

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Gerd Hoffmann
Hi, > Something somewhere in this call chain should have taken > the iothread lock, I assume, but I'm not sure where. > > Gerd -- what are the rules of the UI subsystem regarding > multiple threads, and what threads are allowed to call > UI functions like qemu_input_event_send_key_qcode(), > fr

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Peter Maydell
(Hi Gerd -- I have a question at the bottom of this email about the thread/locking semantics of the UI midlayer...) On 20 November 2018 at 12:59, Peter Maydell wrote: > On 11 November 2018 at 21:24, Berkus Decker wrote: >> It seems that Cocoa checks are stricter on Mojave and some callbacks that

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 05:53:50AM -0500, Programmingkid wrote: > > > On 13 November 2018 at 12:12, Programmingkid > > wrote: > >>> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: > >>> These changes are ought to work on OSX 10.6, although I don?t have a > >>> machine handy to test it. > >>

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Programmingkid
> On 13 November 2018 at 12:12, Programmingkid > wrote: >>> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: >>> These changes are ought to work on OSX 10.6, although I don?t have a >>> machine handy to test it. >> >> I have Mac OS 10.6 available for testing. > > This is perhaps a good poin

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 01:09:54PM +, Peter Maydell wrote: > On 13 November 2018 at 12:12, Programmingkid > wrote: > >> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: > >> These changes are ought to work on OSX 10.6, although I don?t have a > >> machine handy to test it. > > > > I have Ma

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Peter Maydell
On 13 November 2018 at 12:12, Programmingkid wrote: >> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: >> These changes are ought to work on OSX 10.6, although I don?t have a machine >> handy to test it. > > I have Mac OS 10.6 available for testing. This is perhaps a good point to ask the ques

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-20 Thread Peter Maydell
On 11 November 2018 at 21:24, Berkus Decker wrote: > It seems that Cocoa checks are stricter on Mojave and some callbacks that > worked from non-GUI thread on High Sierra are no longer working. > > The fixes included here are: > > * Deferring qemu_main() to another thread so that the actual main

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-14 Thread Berkus Decker
I will double check on High Sierra and El Capitan. So far I only tested qemu-system-aarch64 and it worked on Mojave, but did not test elsewhere (my aim was to get my osdev going, only). I have a range of older osx machines (not as old as 10.6 though), so will put it through some rounds. Will po

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-13 Thread Programmingkid
> On Nov 11, 2018, at 4:35 PM, qemu-devel-requ...@nongnu.org wrote: > > It seems that Cocoa checks are stricter on Mojave and some callbacks that > worked from non-GUI thread on High Sierra are no longer working. > > The fixes included here are: > > * Deferring qemu_main() to another thread s

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-13 Thread Programmingkid
> On Nov 11, 2018, at 4:35 PM, qemu-devel-requ...@nongnu.org wrote: > > It seems that Cocoa checks are stricter on Mojave and some callbacks that > worked from non-GUI thread on High Sierra are no longer working. > > The fixes included here are: > > * Deferring qemu_main() to another thread s

[Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-11 Thread Berkus Decker
It seems that Cocoa checks are stricter on Mojave and some callbacks that worked from non-GUI thread on High Sierra are no longer working. The fixes included here are: * Deferring qemu_main() to another thread so that the actual main thread is reserved for the Cocoa UI; it also removes blocking