Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Laurent Vivier
Le jeudi 10 janvier 2008 à 15:30 +0200, Avi Kivity a écrit : > Johannes Schindelin wrote: > > Hi, > > > > On Thu, 10 Jan 2008, Laurent Vivier wrote: > > > > > >> Perhaps the best solution is to put "file=" option at the end of > >> aliases, '\0' is marking the end of filename (it is likely the

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Avi Kivity
Johannes Schindelin wrote: Hi, On Thu, 10 Jan 2008, Laurent Vivier wrote: Perhaps the best solution is to put "file=" option at the end of aliases, '\0' is marking the end of filename (it is likely the idea of andrzej about special characters). Oh, why not just make it a requirement

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Laurent Vivier
Le jeudi 10 janvier 2008 à 12:15 +, Johannes Schindelin a écrit : > Hi, > > On Thu, 10 Jan 2008, Laurent Vivier wrote: > > > Perhaps the best solution is to put "file=" option at the end of > > aliases, '\0' is marking the end of filename (it is likely the idea of > > andrzej about special

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Johannes Schindelin
Hi, On Thu, 10 Jan 2008, Laurent Vivier wrote: > Perhaps the best solution is to put "file=" option at the end of > aliases, '\0' is marking the end of filename (it is likely the idea of > andrzej about special characters). Oh, why not just make it a requirement that file= comes last, always?

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Laurent Vivier
Le jeudi 10 janvier 2008 à 11:53 +, Johannes Schindelin a écrit : > Hi, > > On Thu, 10 Jan 2008, Laurent Vivier wrote: > > > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > > [...] > > > Besides, it would not be _that_ complicated: > > > > This patch doesn't manage

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Johannes Schindelin
Hi, On Thu, 10 Jan 2008, Laurent Vivier wrote: > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > [...] > > Besides, it would not be _that_ complicated: > > This patch doesn't manage the case where we have comma in filename: > > qemu -drive file=my,file,if=scsi > > wh

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-10 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : [...] > Besides, it would not be _that_ complicated: This patch doesn't manage the case where we have comma in filename: qemu -drive file=my,file,if=scsi where filename is "my,file". Laurent > -- snipsnap -- > [PATCH] make

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 11:53 -0600, Anthony Liguori a écrit : > Laurent Vivier wrote: > > Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : > > > >> On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > >> > >>> Le mercredi 09 janvier 2008 à 10:31 +0100, La

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Johannes Schindelin
Hi, On Wed, 9 Jan 2008, Anthony Liguori wrote: > Laurent Vivier wrote: > > Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : > > > > > On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > > > > > > > Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a é

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Anthony Liguori
Laurent Vivier wrote: Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a é

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 14:56 +0100, andrzej zaborowski a écrit : > On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > > > Hi, > > > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > > > Le mercredi 0

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 13:59 +, Johannes Schindelin a écrit : > Hi, > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > > > Hi, > > > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > > > Le mercredi 0

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Johannes Schindelin
Hi, On Wed, 9 Jan 2008, Laurent Vivier wrote: > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > > Hi, > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > Le mercredi 09 janvier 2008 à 12:27 +, Johannes Schindelin a écrit : > > > > > > > On Wed, 9 Jan 2008

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread andrzej zaborowski
On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > > Hi, > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > Le mercredi 09 janvier 2008 à 12:27 +, Johannes Schindelin a écrit : > > > > > > > On Wed, 9 Ja

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 13:27 +, Johannes Schindelin a écrit : > Hi, > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > Le mercredi 09 janvier 2008 à 12:27 +, Johannes Schindelin a écrit : > > > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > > > but "-hda" is an alias fo

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Johannes Schindelin
Hi, On Wed, 9 Jan 2008, Laurent Vivier wrote: > Le mercredi 09 janvier 2008 à 12:27 +, Johannes Schindelin a écrit : > > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > > > but "-hda" is an alias for "-drive file="%s",index=%d,media=disk". > > > > It appears to me as if "-hda" is impleme

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 13:27 +0100, Andreas Färber a écrit : > Am 09.01.2008 um 13:08 schrieb Laurent Vivier: > > > Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a > > écrit : > >> On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > >>> Le mercredi 09 janvier 2008 à

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 12:27 +, Johannes Schindelin a écrit : > Hi, > > On Wed, 9 Jan 2008, Laurent Vivier wrote: > > > but "-hda" is an alias for "-drive file="%s",index=%d,media=disk". > > It appears to me as if "-hda" is implemented suboptimally, then. In > particular, drive_add(

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread andrzej zaborowski
On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : > > On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > > > Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : > > > > Le mardi 08 janvier 2008

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Andreas Färber
Am 09.01.2008 um 13:08 schrieb Laurent Vivier: Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : Le mardi 08 janvier 2008 à 17:17 +0100, Hervé P

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Johannes Schindelin
Hi, On Wed, 9 Jan 2008, Laurent Vivier wrote: > but "-hda" is an alias for "-drive file="%s",index=%d,media=disk". It appears to me as if "-hda" is implemented suboptimally, then. In particular, drive_add() should be able to get a separate "file" parameter, which can be overridden by the "fmt

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 11:40 +0100, andrzej zaborowski a écrit : > On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > > Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : > > > Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a écrit : > > > > Hi, > > > > > >

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread andrzej zaborowski
On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : > > Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a écrit : > > > Hi, > > > > > > On Windows, since December 2nd, files names provided in command line > > > have

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mercredi 09 janvier 2008 à 10:31 +0100, Laurent Vivier a écrit : > Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a écrit : > > Hi, > > > > On Windows, since December 2nd, files names provided in command line > > have to double their backslash to work correctly, for example: "-hda

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread andrzej zaborowski
On 09/01/2008, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a écrit : > > Hi, > > > > On Windows, since December 2nd, files names provided in command line > > have to double their backslash to work correctly, for example: "-hda > > c:\\disks\\

Re: [Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-09 Thread Laurent Vivier
Le mardi 08 janvier 2008 à 17:17 +0100, Hervé Poussineau a écrit : > Hi, > > On Windows, since December 2nd, files names provided in command line > have to double their backslash to work correctly, for example: "-hda > c:\\disks\\qemu.qcow" instead of -hda c:\disks\qemu.qcow" > This patch remo

[Qemu-devel] [PATCH] Fix double backslash problem in Windows

2008-01-08 Thread Hervé Poussineau
Hi, On Windows, since December 2nd, files names provided in command line have to double their backslash to work correctly, for example: "-hda c:\\disks\\qemu.qcow" instead of -hda c:\disks\qemu.qcow" This patch removes this need and reverts back to Qemu 0.9.0 behaviour Hervé no-double-ba