Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-27 Thread Thomas Huth
On Mon, 27 Apr 2015 13:48:27 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 09/04/2015 20:31, Eric Blake wrote: > >>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c > >>> index 6941a82..b3d5100 100644 > >>> --- a/hw/pci/pci.c > >>> +++ b/hw/pci/pci.c > >>> @@ -1660,7 +1660,9 @@ PCIDe

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/04/2015 20:31, Eric Blake wrote: >>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c >>> index 6941a82..b3d5100 100644 >>> --- a/hw/pci/pci.c >>> +++ b/hw/pci/pci.c >>> @@ -1660,7 +1660,9 @@ PCIDevice *pci_nic_init_nofail(NICInfo *nd, PCIBus >>> *rootbus, >>> >>> re

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-13 Thread Peter Maydell
On 13 April 2015 at 04:01, Jason Wang wrote: > > > On Thu, Apr 9, 2015 at 9:32 PM, Thomas Huth wrote: >> >> Current QEMU crashes when specifying an illegal model with the >> "-net nic,model=xxx" option, e.g.: >> >> $ qemu-system-x86_64 -net nic,model=n/a >> qemu-system-x86_64: Unsupported NIC m

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-12 Thread Jason Wang
On Thu, Apr 9, 2015 at 9:32 PM, Thomas Huth wrote: Current QEMU crashes when specifying an illegal model with the "-net nic,model=xxx" option, e.g.: $ qemu-system-x86_64 -net nic,model=n/a qemu-system-x86_64: Unsupported NIC model: n/a Program received signal SIGSEGV, Segmentation fault.

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-12 Thread Andreas Färber
Am 12.04.2015 um 13:14 schrieb Michael S. Tsirkin: > On Thu, Apr 09, 2015 at 03:48:57PM +0100, Peter Maydell wrote: >> On 9 April 2015 at 14:37, Michael S. Tsirkin wrote: >>> On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: Current QEMU crashes when specifying an illegal model wit

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-12 Thread Michael S. Tsirkin
On Thu, Apr 09, 2015 at 03:48:57PM +0100, Peter Maydell wrote: > On 9 April 2015 at 14:37, Michael S. Tsirkin wrote: > > On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: > >> Current QEMU crashes when specifying an illegal model with the > >> "-net nic,model=xxx" option, e.g.: > >> > >

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-12 Thread Michael S. Tsirkin
On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: > Current QEMU crashes when specifying an illegal model with the > "-net nic,model=xxx" option, e.g.: > > $ qemu-system-x86_64 -net nic,model=n/a > qemu-system-x86_64: Unsupported NIC model: n/a > > Program received signal SIGSEGV, S

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 20:31, Eric Blake wrote: >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c >> index 6941a82..b3d5100 100644 >> --- a/hw/pci/pci.c >> +++ b/hw/pci/pci.c >> @@ -1660,7 +1660,9 @@ PCIDevice *pci_nic_init_nofail(NICInfo *nd, PCIBus >> *rootbus, >> >> res = pci_nic_init(nd, rootbus, de

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Eric Blake
On 04/09/2015 07:32 AM, Thomas Huth wrote: > Current QEMU crashes when specifying an illegal model with the > "-net nic,model=xxx" option, e.g.: > > $ qemu-system-x86_64 -net nic,model=n/a > qemu-system-x86_64: Unsupported NIC model: n/a > > The problem is that pci_nic_init_nofail() does not c

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 14:37, Michael S. Tsirkin wrote: > On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: >> Current QEMU crashes when specifying an illegal model with the >> "-net nic,model=xxx" option, e.g.: >> >> $ qemu-system-x86_64 -net nic,model=n/a >> qemu-system-x86_64: Unsuppor

[Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Thomas Huth
Current QEMU crashes when specifying an illegal model with the "-net nic,model=xxx" option, e.g.: $ qemu-system-x86_64 -net nic,model=n/a qemu-system-x86_64: Unsupported NIC model: n/a Program received signal SIGSEGV, Segmentation fault. The gdb backtrace looks like this: 0x55965fe0

Re: [Qemu-devel] [PATCH] Fix crash with illegal "-net nic, model=xxx" option

2015-04-09 Thread Michael S. Tsirkin
On Thu, Apr 09, 2015 at 03:32:45PM +0200, Thomas Huth wrote: > Current QEMU crashes when specifying an illegal model with the > "-net nic,model=xxx" option, e.g.: > > $ qemu-system-x86_64 -net nic,model=n/a > qemu-system-x86_64: Unsupported NIC model: n/a > > Program received signal SIGSEGV, S