Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread andrzej zaborowski
On 2 June 2010 22:32, Anthony Liguori wrote: > On 06/02/2010 02:31 PM, andrzej zaborowski wrote: >> It seems that what this really tries to do is like *dest = >> leul_to_cpu(v) from bswap.h? (Or cpu_to_leul.. quite difficult to wrap >> my head around it..) >> > > Yeah, I think it possibly should b

Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread Anthony Liguori
On 06/02/2010 02:31 PM, andrzej zaborowski wrote: Hi, On 2 June 2010 20:58, Anthony Liguori wrote: Currently, console_ch_t is defined as an unsigned long. However, immediately after it's definition, we treat it as a uint32_t *. This will work on a little endian system because of the way

Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread andrzej zaborowski
Hi, On 2 June 2010 20:58, Anthony Liguori wrote: > Currently, console_ch_t is defined as an unsigned long.  However, immediately > after it's definition, we treat it as a uint32_t *.  This will work on a > little > endian system because of the way bits are layed out but will fail miserably > on

[Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread Anthony Liguori
Currently, console_ch_t is defined as an unsigned long. However, immediately after it's definition, we treat it as a uint32_t *. This will work on a little endian system because of the way bits are layed out but will fail miserably on big endian hosts. This patch fixes the code to do the correct