Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-08-13 Thread Shaju Abraham
I do not have a test case to reproduce this issue. It is seen rarely. The fix looks good to me, will confirm if I am able to reproduce the error scenario. Regards Shaju On 8/14/19, 4:21 AM, "John Snow" wrote: On 7/7/19 10:55 PM, shaju.abra...@nutanix.com wrote: > From: Shaju

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-08-13 Thread John Snow
On 7/7/19 10:55 PM, shaju.abra...@nutanix.com wrote: > From: Shaju Abraham > > During the IDE DMA transfer for a ISCSI target,when libiscsi encounters > a SENSE KEY error, it sets the task->sense to the value "COMMAND ABORTED". > The function iscsi_translate_sense() later translaters this er

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread Paolo Bonzini
On 29/07/19 23:37, John Snow wrote: >>> >>> If it does -- if there are indeed no places in the code today that >>> artificially inject -ECANCELED -- I need to remove these special stanzas >>> from the IDE code and allow the IDE state machine to handle these errors >>> as true errors. >> The bug is

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread John Snow
On 7/29/19 5:32 PM, Paolo Bonzini wrote: > On 29/07/19 21:45, John Snow wrote: >> Next, we'll unschedule the BH if there is one. I think the only case >> where there is one is the reschedule_dma case of dma_blk_cb. (I'm not >> too familiar with these DMA helpers: in what cases do we expect the i

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread Paolo Bonzini
On 29/07/19 21:45, John Snow wrote: > Next, we'll unschedule the BH if there is one. I think the only case > where there is one is the reschedule_dma case of dma_blk_cb. (I'm not > too familiar with these DMA helpers: in what cases do we expect the iov > to be empty?) When there is another I/O tha

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread John Snow
On 7/29/19 6:09 AM, Stefan Hajnoczi wrote: > On Fri, Jul 26, 2019 at 04:18:46PM -0400, John Snow wrote: >> Paolo, Stefan and Kevin: can I loop you in here? I'm quite uncertain >> about this and I'd like to clear this up quickly if it's possible: >> >> On 7/25/19 8:58 PM, John Snow wrote: >>> >>>

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread Stefan Hajnoczi
On Fri, Jul 26, 2019 at 04:18:46PM -0400, John Snow wrote: > Paolo, Stefan and Kevin: can I loop you in here? I'm quite uncertain > about this and I'd like to clear this up quickly if it's possible: > > On 7/25/19 8:58 PM, John Snow wrote: > > > > > > On 7/7/19 10:55 PM, shaju.abra...@nutanix.co

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-26 Thread John Snow
Paolo, Stefan and Kevin: can I loop you in here? I'm quite uncertain about this and I'd like to clear this up quickly if it's possible: On 7/25/19 8:58 PM, John Snow wrote: > > > On 7/7/19 10:55 PM, shaju.abra...@nutanix.com wrote: >> From: Shaju Abraham >> >> During the IDE DMA transfer for a

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-25 Thread John Snow
On 7/7/19 10:55 PM, shaju.abra...@nutanix.com wrote: > From: Shaju Abraham > > During the IDE DMA transfer for a ISCSI target,when libiscsi encounters > a SENSE KEY error, it sets the task->sense to the value "COMMAND ABORTED". > The function iscsi_translate_sense() later translaters this er

[Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-08 Thread shaju . abraham
From: Shaju Abraham During the IDE DMA transfer for a ISCSI target,when libiscsi encounters a SENSE KEY error, it sets the task->sense to the value "COMMAND ABORTED". The function iscsi_translate_sense() later translaters this error to -ECANCELED and this value is passed to the callback functio