Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-25 Thread Markus Armbruster
Blue Swirl writes: > On Sat, Jul 24, 2010 at 12:03 PM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> Command line flag '-snapshot' was setting the drive flag 'snapshot' >>> for all drives. Therefore also CDROM devices were incorrectly marked >>> with BDRV_O_SNAPSHOT. Thus the backing im

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-25 Thread Blue Swirl
On Sat, Jul 24, 2010 at 12:03 PM, Markus Armbruster wrote: > Blue Swirl writes: > >> Command line flag '-snapshot' was setting the drive flag 'snapshot' >> for all drives. Therefore also CDROM devices were incorrectly marked >> with BDRV_O_SNAPSHOT. Thus the backing images were accidentally delet

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-24 Thread Markus Armbruster
Blue Swirl writes: > Command line flag '-snapshot' was setting the drive flag 'snapshot' > for all drives. Therefore also CDROM devices were incorrectly marked > with BDRV_O_SNAPSHOT. Thus the backing images were accidentally deleted > at bdrv_open time, for example when changing the image with m

[Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-23 Thread Blue Swirl
Command line flag '-snapshot' was setting the drive flag 'snapshot' for all drives. Therefore also CDROM devices were incorrectly marked with BDRV_O_SNAPSHOT. Thus the backing images were accidentally deleted at bdrv_open time, for example when changing the image with monitor 'change' command. Fix