Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Hervé Poussineau
Hi, Miki Mishael a écrit : Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.i

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Gerd Hoffmann
On Do, 2014-01-16 at 07:18 -0500, Miki Mishael wrote: > Support for pci-serial-2x and pci-serial-4x > added to inf file. > Standard Windows driver mf.sys used to > split single function > device into per-port nodes. Patch looks good. Not that I understand everything

[Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.inf | 227 +

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-13 Thread Michael S. Tsirkin
On Mon, Jan 13, 2014 at 03:56:49PM +0100, Paolo Bonzini wrote: > Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto: > > > > if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) { > > printk(KERN_ERR "virtio_pci: expected ABI version %d, > > got %d\n", > >

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-13 Thread Paolo Bonzini
Il 13/01/2014 16:03, Michael S. Tsirkin ha scritto: >>> > > so it seems better to be consistent. >>> > > in any case, we must check subsystem ids, the spec is very >>> > > explicit on this point. >> > >> > This is not a virtio device. >> > >> > Paolo > oh > I didn't realize that - thought it's vi

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-13 Thread Paolo Bonzini
Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto: > > if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) { > printk(KERN_ERR "virtio_pci: expected ABI version %d, > got %d\n", >VIRTIO_PCI_ABI_VERSION, pci_dev->revision); > return -ENO

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-13 Thread Michael S. Tsirkin
On Mon, Jan 13, 2014 at 11:13:07AM +0100, Gerd Hoffmann wrote: > On Mi, 2014-01-08 at 17:11 +0100, Paolo Bonzini wrote: > > Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: > > >>> > > >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, > > >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01 > > >>> +%QEMU-PC

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-13 Thread Gerd Hoffmann
On Mi, 2014-01-08 at 17:11 +0100, Paolo Bonzini wrote: > Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: > >>> > >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, > >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01 > >>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2, > >>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Michael S. Tsirkin
On Wed, Jan 08, 2014 at 05:11:48PM +0100, Paolo Bonzini wrote: > Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: > >>> > >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, > >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01 > >>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2, > >>> PCI\VEN_1B36&DEV_0003&SUBSYS_

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 16:07, Yan Vugenfirer ha scritto: >>> >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1, >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01 >>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2, >>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01 >>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4, >>> PCI\VEN_1B

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-08 Thread Yan Vugenfirer
On Jan 7, 2014, at 4:45 PM, Paolo Bonzini wrote: > Il 05/01/2014 16:04, Miki Mishael ha scritto: >> Support for pci-serial-2x and pci-serial-4x added to inf file. >> Standard Windows driver mf.sys used to split single function >> device into per-port nodes. >> >> Signed-off-by: Miki Mishael >>

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-07 Thread Paolo Bonzini
Il 05/01/2014 16:04, Miki Mishael ha scritto: > Support for pci-serial-2x and pci-serial-4x added to inf file. > Standard Windows driver mf.sys used to split single function > device into per-port nodes. > > Signed-off-by: Miki Mishael > Signed-off-by: Dmitry Fleytman > --- > docs/qemupciserial

[Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf

2014-01-05 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.inf | 227 ++---