Re: [Qemu-devel] [PATCH] Check correct register for clock source

2019-09-13 Thread Amithash Prasad
>> yes. I have pushed it on the aspeed-4.2 branch but it can go independently >>as there are no conflicts. I changed the title slightly to reflect the >> area being changed. Thanks! If required, I can change the patch title and resubmit.

Re: [Qemu-devel] [PATCH] Check correct register for clock source

2019-09-06 Thread Cédric Le Goater
On 06/09/2019 03:16, Joel Stanley wrote: > On Fri, 6 Sep 2019 at 01:10, Amithash Prasad wrote: >> >> When WDT_RESTART is written, the data is not the contents >> of the WDT_CTRL register. Hence ensure we are looking at >> WDT_CTRL to check if bit WDT_CTRL_1MHZ_CLK is set or not. >> >> Signed-off-b

[Qemu-devel] [PATCH] Check correct register for clock source

2019-09-05 Thread Amithash Prasad
When WDT_RESTART is written, the data is not the contents of the WDT_CTRL register. Hence ensure we are looking at WDT_CTRL to check if bit WDT_CTRL_1MHZ_CLK is set or not. Signed-off-by: Amithash Prasad --- hw/watchdog/wdt_aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Qemu-devel] [PATCH] Check correct register for clock source

2019-09-05 Thread Joel Stanley
On Fri, 6 Sep 2019 at 01:10, Amithash Prasad wrote: > > When WDT_RESTART is written, the data is not the contents > of the WDT_CTRL register. Hence ensure we are looking at > WDT_CTRL to check if bit WDT_CTRL_1MHZ_CLK is set or not. > > Signed-off-by: Amithash Prasad Reviewed-by: Joel Stanley